Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1588683002: Add Audittrail for path renderers (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/gpu/GrDrawTarget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
joshualitt
One thing I have some slight reservations about is the getter on drawtarget. I could ...
4 years, 11 months ago (2016-01-13 19:59:24 UTC) #3
robertphillips
I'm okay with the getter but Brian may want to weigh in. lgtm.
4 years, 11 months ago (2016-01-13 20:44:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588683002/1
4 years, 11 months ago (2016-01-14 17:46:08 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:58:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de83b41cc7fc5bd1398e06c011e698215261665f

Powered by Google App Engine
This is Rietveld 408576698