Virtualize Frames in GrAuditTrail

Virtualize Frames in GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1581943004

Committed: https://skia.googlesource.com/skia/+/11fae87d39811882e3e99b4abc72c9713a38da55

[joshua.litt, 2016-01-14 14:26:25]

Description was changed from

==========
Virtualize Frames in GrAuditTrail

BUG=skia:
==========

to

==========
Virtualize Frames in GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-14 14:28:10]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[bsalomon, 2016-01-14 14:57:28]

lgtm, w/ some suggestions

https://codereview.chromium.org/1581943004/diff/20001/include/private/GrAudit...
File include/private/GrAuditTrail.h (right):

https://codereview.chromium.org/1581943004/diff/20001/include/private/GrAudit...
include/private/GrAuditTrail.h:76: struct FrameBase {
Seems like this isn't really a Frame anymore... Maybe Event?

https://codereview.chromium.org/1581943004/diff/20001/include/private/GrAudit...
include/private/GrAuditTrail.h:94: SkTArray<SkAutoTDelete<FrameBase>, true>
fFrames;
Fairly verbose type and you're using it as a param type in the cpp, maybe
typedef it in case you change your mind later?

[robertphillips, 2016-01-14 16:38:56]

lgtm

https://codereview.chromium.org/1581943004/diff/40001/include/private/GrAudit...
File include/private/GrAuditTrail.h (right):

https://codereview.chromium.org/1581943004/diff/40001/include/private/GrAudit...
include/private/GrAuditTrail.h:85: SkString toJson() const override;
Can we use FrameArray to define fChildren too ?

[joshualitt, 2016-01-14 18:44:22]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-01-14 18:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1581943004/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-01-14 18:44:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1581943004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1581943004/60001

[commit-bot: I haz the power, 2016-01-14 18:58:09]

Description was changed from

==========
Virtualize Frames in GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Virtualize Frames in GrAuditTrail

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/11fae87d39811882e3e99b4abc72c9713a38da55
==========

[commit-bot: I haz the power, 2016-01-14 18:58:10]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/11fae87d39811882e3e99b4abc72c9713a38da55