Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 1602403002: Revert of Remove remote tree host and some related input and metro_driver code (Closed)

Created:
4 years, 11 months ago by samli
Modified:
4 years, 11 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jam, kalyank, nona+watch_chromium.org, noyau+watch_chromium.org, sadrul, shuchen+watch_chromium.org, James Su, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove remote tree host and some related input and metro_driver code (patchset #5 id:80001 of https://codereview.chromium.org/1586843002/ ) Reason for revert: Suspecting that this is breaking the Webkit Win (dbg) builder. First failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/88362 Original issue's description: > Remove remote tree host and some related input and metro_driver code > > Part of continued stripping out of Metro/Win8/Immersive mode. > > BUG=558054 > > Committed: https://crrev.com/5cc04f70e424020d8afe49bdc4c1c76683f0ea7b > Cr-Commit-Position: refs/heads/master@{#370068} TBR=sky@chromium.org,thestig@chromium.org,shuchen@chromium.org,ananta@chromium.org,dpranke@chromium.org,scottmg@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=558054 Committed: https://crrev.com/0e3a9fd80a26f1fce889200d330d79e64d7a2586 Cr-Commit-Position: refs/heads/master@{#370290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8006 lines, -4 lines) Patch
M ash/ash.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/ash_unittests.isolate View 2 chunks +15 lines, -1 line 0 comments Download
A ash/host/ash_remote_window_tree_host_win.h View 1 chunk +53 lines, -0 lines 0 comments Download
A ash/host/ash_remote_window_tree_host_win.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part.h View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/browser_process_platform_part_aurawin.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/browser_process_platform_part_aurawin.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/metro_viewer/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/metro_viewer/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 chunk +174 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/launcher/chrome_launcher_controller_chromeos.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/launcher/chrome_launcher_controller_win.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.win.json View 6 chunks +21 lines, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/aura/remote_window_tree_host_win.h View 1 chunk +197 lines, -0 lines 0 comments Download
A ui/aura/remote_window_tree_host_win.cc View 1 chunk +522 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A ui/base/ime/remote_input_method_delegate_win.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ui/base/ime/remote_input_method_win.h View 1 chunk +100 lines, -0 lines 0 comments Download
A ui/base/ime/remote_input_method_win.cc View 1 chunk +385 lines, -0 lines 0 comments Download
A ui/base/ime/remote_input_method_win_unittest.cc View 1 chunk +831 lines, -0 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +54 lines, -0 lines 0 comments Download
M ui/shell_dialogs/shell_dialogs.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M win8/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
M win8/delegate_execute/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M win8/metro_driver/BUILD.gn View 3 chunks +10 lines, -0 lines 0 comments Download
A win8/metro_driver/chrome_app_view_ash.h View 1 chunk +262 lines, -0 lines 0 comments Download
A win8/metro_driver/chrome_app_view_ash.cc View 1 chunk +1464 lines, -0 lines 0 comments Download
A win8/metro_driver/file_picker.h View 1 chunk +18 lines, -0 lines 0 comments Download
A win8/metro_driver/file_picker.cc View 1 chunk +622 lines, -0 lines 0 comments Download
A win8/metro_driver/file_picker_ash.h View 1 chunk +157 lines, -0 lines 0 comments Download
A win8/metro_driver/file_picker_ash.cc View 1 chunk +619 lines, -0 lines 0 comments Download
A win8/metro_driver/metro_driver.h View 1 chunk +17 lines, -0 lines 0 comments Download
A win8/metro_driver/metro_driver.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 3 chunks +12 lines, -0 lines 0 comments Download
A win8/metro_driver/metro_driver_win7.cc View 1 chunk +1229 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_constants.h View 1 chunk +20 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_constants.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_exports.h View 1 chunk +29 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_process_host.h View 1 chunk +221 lines, -0 lines 0 comments Download
A win8/viewer/metro_viewer_process_host.cc View 1 chunk +346 lines, -0 lines 0 comments Download
M win8/win8.gyp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
samli
Created Revert of Remove remote tree host and some related input and metro_driver code
4 years, 11 months ago (2016-01-20 03:05:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602403002/1
4 years, 11 months ago (2016-01-20 03:06:31 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/137037)
4 years, 11 months ago (2016-01-20 03:17:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602403002/1
4 years, 11 months ago (2016-01-20 03:42:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 03:45:05 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e3a9fd80a26f1fce889200d330d79e64d7a2586 Cr-Commit-Position: refs/heads/master@{#370290}
4 years, 11 months ago (2016-01-20 03:46:17 UTC) #13
samli
4 years, 11 months ago (2016-01-20 04:02:56 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1605253002/ by samli@chromium.org.

The reason for reverting is: Didn't help, looks like the slave is out of disk
space..

Powered by Google App Engine
This is Rietveld 408576698