Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1585463002: Use sysroot for chromeos builds (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chirantan+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use sysroot for chromeos builds Previously the sysroot was only being used for non-chromeos linux builds because it lacked certain packages. CLOCK_REALTIME_ALARM is not defined by bits/time.h in wheezy so all use of this macro must be conditionalized. gn: libssl is now only included in the build if use_openssl is not set which matches the gyp logic. BUG=506663

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -111 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/config/sysroot.gni View 1 chunk +1 line, -1 line 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/timers/alarm_timer_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 1 2 2 chunks +113 lines, -109 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 38 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/20001
4 years, 11 months ago (2016-01-13 00:07:58 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/110230)
4 years, 11 months ago (2016-01-13 01:28:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/20001
4 years, 11 months ago (2016-01-13 18:34:40 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/129142)
4 years, 11 months ago (2016-01-13 19:51:43 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/60001
4 years, 11 months ago (2016-01-13 21:57:01 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 1581803006 Patch 20001). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-13 23:24:34 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/80001
4 years, 11 months ago (2016-01-13 23:35:02 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) ...
4 years, 11 months ago (2016-01-14 01:40:59 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/80001
4 years, 10 months ago (2016-02-19 03:55:55 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/127538)
4 years, 10 months ago (2016-02-19 05:47:48 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/80001
4 years, 10 months ago (2016-02-19 17:24:34 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/169230)
4 years, 10 months ago (2016-02-19 19:39:16 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585463002/80001
4 years, 10 months ago (2016-02-24 22:14:44 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/179043)
4 years, 10 months ago (2016-02-24 23:20:09 UTC) #33
drott
Are you planning to land this? The Win CQ failure was probably a flake.
4 years, 9 months ago (2016-03-04 15:40:24 UTC) #34
Sam Clegg
On 2016/03/04 15:40:24, drott wrote: > Are you planning to land this? The Win CQ ...
4 years, 9 months ago (2016-03-04 23:34:27 UTC) #35
Sam Clegg
4 years, 9 months ago (2016-03-04 23:35:57 UTC) #37
+thestig since he can probably help out with landing this once the jessie update
lands.

I'm going on leave for 6 months so probably won't be around to land this change.

Powered by Google App Engine
This is Rietveld 408576698