Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1581803006:
common.gypi: check for chromeos==1 rather than OS==chromeos (Closed)
Descriptioncommon.gypi: check for chromeos==1 rather than OS==chromeos
There is no OS==chromeos in gyp, only OS==linux + chromeos==1
Committed: https://crrev.com/7d75453b1d39a44e1e386a221c49cbcc2d569a8b
Cr-Commit-Position: refs/heads/master@{#376369}
Patch Set 1 #Patch Set 2 : #
Total comments: 3
Dependent Patchsets: Messages
Total messages: 23 (10 generated)
Description was changed from ========== common.gypi: check for chromeos==1 rather then OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 ========== to ========== common.gypi: check for chromeos==1 rather than OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 ==========
sbc@chromium.org changed reviewers: + dnicoara@chromium.org, thakis@chromium.org
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581803006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581803006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581803006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581803006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi#oldco... build/common.gypi:2399: 'ozone_platform_egltest%': 1, Why is this removing ozone_platform_egltest?
https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi#oldco... build/common.gypi:2399: 'ozone_platform_egltest%': 1, On 2016/02/17 22:59:32, dnicoara wrote: > Why is this removing ozone_platform_egltest? It was set in both sides of the condition so I just moved it out. Should be a no-op.
lgtm https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1581803006/diff/20001/build/common.gypi#oldco... build/common.gypi:2399: 'ozone_platform_egltest%': 1, On 2016/02/17 23:01:10, Sam Clegg wrote: > On 2016/02/17 22:59:32, dnicoara wrote: > > Why is this removing ozone_platform_egltest? > > It was set in both sides of the condition so I just moved it out. Should be a > no-op. Ah, I see, sorry, missed it.
ping thakis@ for OWNERS
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581803006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581803006/20001
Message was sent while issue was closed.
Description was changed from ========== common.gypi: check for chromeos==1 rather than OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 ========== to ========== common.gypi: check for chromeos==1 rather than OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== common.gypi: check for chromeos==1 rather than OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 ========== to ========== common.gypi: check for chromeos==1 rather than OS==chromeos There is no OS==chromeos in gyp, only OS==linux + chromeos==1 Committed: https://crrev.com/7d75453b1d39a44e1e386a221c49cbcc2d569a8b Cr-Commit-Position: refs/heads/master@{#376369} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7d75453b1d39a44e1e386a221c49cbcc2d569a8b Cr-Commit-Position: refs/heads/master@{#376369} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
