Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1585383003: Add deprecation message for -webkit-background-composite (Closed)

Created:
4 years, 11 months ago by nainar
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add deprecation message for -webkit-background-composite This patch is two fold: 1. Adds the capability of adding deprecation messages for CSSPropertyIDs as they are parsed. 2. Adds the relevant deprecation message for -webkit-background-composite. The reasons for which are highlighted here https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/thxrbc8XOmc BUG=498588 Committed: https://crrev.com/6d2d7c3b60d3e5cd9b2efd7120cae737ad1e4329 Cr-Commit-Position: refs/heads/master@{#372040} Committed: https://crrev.com/7bec9324105fffca809410f7f0bb5682be117bcc Cr-Commit-Position: refs/heads/master@{#372634}

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Total comments: 8

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Total comments: 19

Patch Set 8 : #

Total comments: 8

Patch Set 9 : #

Total comments: 3

Patch Set 10 : #

Patch Set 11 : Rebased #

Patch Set 12 : #

Patch Set 13 : #

Total comments: 1

Patch Set 14 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/bgCompositeCopy-expected.txt View 1 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/composite-highlight-is-invalid-expected.txt View 1 2 3 4 12 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/multiple-backgrounds-computed-style-expected.txt View 1 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/webkit-background-composite-deprecated.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/webkit-background-composite-deprecated-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/frame/Deprecation.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +65 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -1 line 1 comment Download
M third_party/WebKit/Source/core/page/Page.h View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 54 (15 generated)
nainar
4 years, 11 months ago (2016-01-15 04:27:48 UTC) #2
nainar
4 years, 11 months ago (2016-01-15 05:06:58 UTC) #4
nainar
@alan, PTAL? Thanks!
4 years, 11 months ago (2016-01-18 00:30:57 UTC) #6
alancutter (OOO until 2018)
https://codereview.chromium.org/1585383003/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.cpp File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1585383003/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.cpp#newcode709 third_party/WebKit/Source/core/frame/UseCounter.cpp:709: void UseCounter::countDeprecation(LocalFrame* frame, CSSPropertyID cssPropertyID) const LocalFrame*. https://codereview.chromium.org/1585383003/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.cpp#newcode713 third_party/WebKit/Source/core/frame/UseCounter.cpp:713: ...
4 years, 11 months ago (2016-01-18 04:00:44 UTC) #7
nainar
Made changes. PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.cpp File third_party/WebKit/Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1585383003/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.cpp#newcode709 third_party/WebKit/Source/core/frame/UseCounter.cpp:709: void UseCounter::countDeprecation(LocalFrame* frame, CSSPropertyID cssPropertyID) ...
4 years, 11 months ago (2016-01-18 06:09:55 UTC) #8
alancutter (OOO until 2018)
lgtm with nit. https://codereview.chromium.org/1585383003/diff/40001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1585383003/diff/40001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1002 third_party/WebKit/Source/core/frame/UseCounter.h:1002: // CSSPropertyIDs that aren't deprecated don't ...
4 years, 11 months ago (2016-01-20 00:58:27 UTC) #9
nainar
@timloh PTAL? Thanks!
4 years, 11 months ago (2016-01-20 01:19:13 UTC) #11
nainar
@timloh, I have split up deprecation warnings for CSSProperties into a separate file. I think ...
4 years, 11 months ago (2016-01-20 09:32:19 UTC) #12
alancutter (OOO until 2018)
https://codereview.chromium.org/1585383003/diff/80001/third_party/WebKit/Source/core/frame/DeprecationHelper.cpp File third_party/WebKit/Source/core/frame/DeprecationHelper.cpp (right): https://codereview.chromium.org/1585383003/diff/80001/third_party/WebKit/Source/core/frame/DeprecationHelper.cpp#newcode79 third_party/WebKit/Source/core/frame/DeprecationHelper.cpp:79: } Don't copy paste this, expose it as a ...
4 years, 11 months ago (2016-01-21 00:58:38 UTC) #13
nainar
@alancutter and @timloh, PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/80001/third_party/WebKit/Source/core/frame/DeprecationHelper.cpp File third_party/WebKit/Source/core/frame/DeprecationHelper.cpp (right): https://codereview.chromium.org/1585383003/diff/80001/third_party/WebKit/Source/core/frame/DeprecationHelper.cpp#newcode79 third_party/WebKit/Source/core/frame/DeprecationHelper.cpp:79: } Done. https://codereview.chromium.org/1585383003/diff/80001/third_party/WebKit/Source/core/frame/DeprecationHelper.h File ...
4 years, 11 months ago (2016-01-21 02:39:07 UTC) #14
alancutter (OOO until 2018)
lgtm with nits. https://codereview.chromium.org/1585383003/diff/100001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1585383003/diff/100001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode53 third_party/WebKit/Source/core/frame/Deprecation.cpp:53: return; These ifs can be combined, ...
4 years, 11 months ago (2016-01-21 02:45:57 UTC) #15
nainar
@timloh PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/100001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1585383003/diff/100001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode53 third_party/WebKit/Source/core/frame/Deprecation.cpp:53: return; Done. https://codereview.chromium.org/1585383003/diff/100001/third_party/WebKit/Source/core/frame/Deprecation.h File third_party/WebKit/Source/core/frame/Deprecation.h (right): ...
4 years, 11 months ago (2016-01-21 02:55:47 UTC) #16
Timothy Loh
https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/LayoutTests/TestExpectations#newcode1289 third_party/WebKit/LayoutTests/TestExpectations:1289: crbug.com/498588 fast/backgrounds/background-clip-text-composited.html [ NeedsRebaseline ] why? https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp ...
4 years, 11 months ago (2016-01-25 00:40:00 UTC) #17
alancutter (OOO until 2018)
https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode50 third_party/WebKit/Source/core/frame/Deprecation.cpp:50: if (!frame && frame->host() && !host->deprecation().isSuppressed(propertyID)) On 2016/01/25 at ...
4 years, 11 months ago (2016-01-25 03:13:36 UTC) #18
nainar
@timloh, PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1585383003/diff/120001/third_party/WebKit/LayoutTests/TestExpectations#newcode1289 third_party/WebKit/LayoutTests/TestExpectations:1289: crbug.com/498588 fast/backgrounds/background-clip-text-composited.html [ NeedsRebaseline ] The ...
4 years, 11 months ago (2016-01-25 03:48:24 UTC) #19
Timothy Loh
https://codereview.chromium.org/1585383003/diff/140001/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp File third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp (right): https://codereview.chromium.org/1585383003/diff/140001/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp#newcode696 third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp:696: if (m_styleSheet && m_styleSheet->singleOwnerDocument() && unresolvedProperty != CSSPropertyInvalid) Probably ...
4 years, 11 months ago (2016-01-25 04:48:41 UTC) #20
nainar
@timloh, PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/140001/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp File third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp (right): https://codereview.chromium.org/1585383003/diff/140001/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp#newcode696 third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp:696: if (m_styleSheet && m_styleSheet->singleOwnerDocument() && unresolvedProperty ...
4 years, 11 months ago (2016-01-25 05:33:22 UTC) #21
Timothy Loh
https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right): https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp#newcode75 third_party/WebKit/Source/core/css/StyleSheetContents.cpp:75: : m_ownerRule(o.m_ownerRule) what doesn't work if you don't change ...
4 years, 11 months ago (2016-01-27 00:56:45 UTC) #22
nainar
@timloh, PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right): https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp#newcode75 third_party/WebKit/Source/core/css/StyleSheetContents.cpp:75: : m_ownerRule(o.m_ownerRule) There is no difference ...
4 years, 11 months ago (2016-01-27 07:50:43 UTC) #23
alancutter (OOO until 2018)
https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right): https://codereview.chromium.org/1585383003/diff/160001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp#newcode75 third_party/WebKit/Source/core/css/StyleSheetContents.cpp:75: : m_ownerRule(o.m_ownerRule) On 2016/01/27 at 07:50:42, nainar wrote: > ...
4 years, 11 months ago (2016-01-27 23:34:35 UTC) #24
nainar
Tested in Chrome debug build. No crashes observed.
4 years, 11 months ago (2016-01-28 00:26:41 UTC) #25
Timothy Loh
lgtm
4 years, 11 months ago (2016-01-28 03:17:11 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585383003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585383003/180001
4 years, 11 months ago (2016-01-28 03:19:43 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139929)
4 years, 11 months ago (2016-01-28 03:29:57 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585383003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585383003/200001
4 years, 11 months ago (2016-01-28 04:08:12 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/171575)
4 years, 11 months ago (2016-01-28 05:33:44 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585383003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585383003/200001
4 years, 11 months ago (2016-01-28 05:50:40 UTC) #38
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 11 months ago (2016-01-28 07:12:39 UTC) #39
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/6d2d7c3b60d3e5cd9b2efd7120cae737ad1e4329 Cr-Commit-Position: refs/heads/master@{#372040}
4 years, 11 months ago (2016-01-28 07:13:55 UTC) #41
Noel Gordon
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fbackgrounds%2Fwebkit-background-composite-deprecated.html&showLargeExpectations=true broken and blink tree going red most bots.
4 years, 11 months ago (2016-01-28 08:53:55 UTC) #42
Noel Gordon
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/1648593002/ by noel@chromium.org. ...
4 years, 11 months ago (2016-01-28 08:55:09 UTC) #43
nainar
@timloh, Post revert I have made the following changes: 1. Removed the original LayoutTests that ...
4 years, 10 months ago (2016-02-01 00:48:35 UTC) #44
nainar
@timloh, PTAL? Thanks!
4 years, 10 months ago (2016-02-01 07:35:43 UTC) #45
nainar
https://codereview.chromium.org/1585383003/diff/240001/third_party/WebKit/Source/core/page/Page.cpp File third_party/WebKit/Source/core/page/Page.cpp (right): https://codereview.chromium.org/1585383003/diff/240001/third_party/WebKit/Source/core/page/Page.cpp#newcode501 third_party/WebKit/Source/core/page/Page.cpp:501: deprecation().clearSuppression(); Addition: Clearing all suppression bits here.
4 years, 10 months ago (2016-02-01 07:37:03 UTC) #46
nainar
Made changes. PTAL? Thanks! https://codereview.chromium.org/1585383003/diff/260001/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1585383003/diff/260001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode18 third_party/WebKit/Source/core/frame/Deprecation.cpp:18: } removed m_cssPropertyDeprecationBits.clearAll(); https://codereview.chromium.org/1585383003/diff/260001/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode21 third_party/WebKit/Source/core/frame/Deprecation.cpp:21: ...
4 years, 10 months ago (2016-02-01 07:48:42 UTC) #47
Timothy Loh
still ok
4 years, 10 months ago (2016-02-01 07:50:03 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585383003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585383003/260001
4 years, 10 months ago (2016-02-01 07:50:56 UTC) #51
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 10 months ago (2016-02-01 10:53:26 UTC) #52
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:54:38 UTC) #54
Message was sent while issue was closed. 
Patchset 14 (id:??) landed as
https://crrev.com/7bec9324105fffca809410f7f0bb5682be117bcc
Cr-Commit-Position: refs/heads/master@{#372634}

Powered by Google App Engine
This is Rietveld 408576698