Add deprecation message for -webkit-background-composite

third_party/WebKit/Source/core/frame/UseCounter.cpp

 /*
  * Copyright (C) 2012 Google, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 688 matching lines @@
     if (!host)
         return;
 
     if (!host->useCounter().hasRecordedMeasurement(feature)) {
         host->useCounter().recordMeasurement(feature);
         ASSERT(!deprecationMessage(feature).isEmpty());
         frame->console().addMessage(ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, deprecationMessage(feature)));
     }
 }
 
+void UseCounter::countDeprecation(LocalFrame* frame, CSSPropertyID cssPropertyID)

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

const LocalFrame*.

[nainar, 2016/01/18 06:09:55]

Done.

+{
+    if (!frame)
+        return;
+    FrameHost* host = frame->host();

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

No need for local variable.

[nainar, 2016/01/18 06:09:55]

Done.

+    if (!host)

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

You can merge these two ifs together.

[nainar, 2016/01/18 06:09:55]

Done.

+        return;
+
+    if (!deprecationMessage(cssPropertyID).isEmpty())

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

Avoid calling deprecationMessage() twice.

[nainar, 2016/01/18 06:09:55]

Done.

+        frame->console().addMessage(ConsoleMessage::create(DeprecationMessageSource, WarningMessageLevel, deprecationMessage(cssPropertyID)));
+}
+
 void UseCounter::countDeprecation(ExecutionContext* context, Feature feature)
 {
     if (!context)
         return;
     if (context->isDocument()) {
         UseCounter::countDeprecation(*toDocument(context), feature);
         return;
     }
     if (context->isWorkerGlobalScope())
         toWorkerGlobalScope(context)->countDeprecation(feature);
 }
 
 void UseCounter::countDeprecation(const Document& document, Feature feature)
 {
     UseCounter::countDeprecation(document.frame(), feature);
 }
 
 void UseCounter::countDeprecationIfNotPrivateScript(v8::Isolate* isolate, ExecutionContext* context, Feature feature)
 {
     if (DOMWrapperWorld::current(isolate).isPrivateScriptIsolatedWorld())
         return;
     UseCounter::countDeprecation(context, feature);
 }
 
 static const char* milestoneString(int milestone)
 {
     switch (milestone) {
     case 50:
         return "M50, around April 2016";
+    case 51:
+        return "M51, around June 2016";
     case 53:
         return "M53, around September 2016";
     }
 
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 static String replacedBy(const char* feature, const char* replacement)
 {
     return String::format("%s is deprecated. Please use %s instead.", feature, replacement);
 }
 
 static String willBeRemoved(const char* feature, int milestone, const char* details)
 {
     return String::format("%s is deprecated and will be removed in %s. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), details);
 }
 
 static String replacedWillBeRemoved(const char* feature, const char* replacement, int milestone, const char* details)
 {
     return String::format("%s is deprecated and will be removed in %s. Please use %s instead. See https://www.chromestatus.com/features/%s for more details.", feature, milestoneString(milestone), replacement, details);
 }
 
+String UseCounter::deprecationMessage(CSSPropertyID cssPropertyID)
+{
+    switch (cssPropertyID) {
+    case CSSPropertyWebkitBackgroundComposite:
+        return willBeRemoved("'-webkit-background-composite'", 51, "6607299456008192");
+    // CSSPropertyIDs that aren't deprecated don't have a deprecation message.

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

Instead of this comment have a comment in the header stating that CSS properties
that aren't deprecated will return an empty string.

[nainar, 2016/01/18 06:09:55]

Done.

+    default:
+        return String();

[alancutter (OOO until 2018), 2016/01/18 04:00:44]

Use emptyString().

[nainar, 2016/01/18 06:09:54]

Done.

+    }
+}
+
 String UseCounter::deprecationMessage(Feature feature)
 {
     switch (feature) {
     // Quota
     case PrefixedStorageInfo:
         return replacedBy("'window.webkitStorageInfo'", "'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage'");
 
     // Keyboard Event (DOM Level 3)
     case KeyboardEventKeyLocation:
         return replacedWillBeRemoved("'KeyboardEvent.keyLocation'", "'KeyboardEvent.location'", 50, "4997403308457984");
@@ skipping 246 matching lines @@
 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
 {
     // FIXME: We may want to handle stylesheets that have multiple owners
     //        https://crbug.com/242125
     if (sheetContents && sheetContents->hasSingleOwnerNode())
         return getFrom(sheetContents->singleOwnerDocument());
     return 0;
 }
 
 } // namespace blink