Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: third_party/WebKit/Source/core/frame/DeprecationHelper.h

Issue 1585383003: Add deprecation message for -webkit-background-composite (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google, Inc. All rights reserved. 2 * Copyright (C) 2016 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef FetchInitiatorInfo_h 26 #ifndef DeprecationHelper_h
27 #define FetchInitiatorInfo_h 27 #define DeprecationHelper_h
28 28
29 #include "wtf/Allocator.h" 29 #include "core/CSSPropertyNames.h"
30 #include "wtf/text/AtomicString.h" 30 #include "core/CoreExport.h"
31 #include "wtf/text/TextPosition.h" 31 #include "wtf/BitVector.h"
32 #include "wtf/Noncopyable.h"
33 #include "wtf/OwnPtr.h"
34 #include "wtf/PassOwnPtr.h"
35 #include "wtf/text/WTFString.h"
36 #include <v8.h>
32 37
33 namespace blink { 38 namespace blink {
34 39
35 struct FetchInitiatorInfo { 40 class LocalFrame;
41
42 class DeprecationHelper {
alancutter (OOO until 2018) 2016/01/21 00:58:38 Probably don't need "Helper" in the name.
nainar 2016/01/21 02:39:07 Done.
36 DISALLOW_NEW(); 43 DISALLOW_NEW();
37 FetchInitiatorInfo() 44 WTF_MAKE_NONCOPYABLE(DeprecationHelper);
38 : name() 45 public:
39 , position(TextPosition::belowRangePosition()) 46 DeprecationHelper();
40 , startTime(0.0) 47 ~DeprecationHelper();
48
49 void count(CSSPropertyID propertyID)
alancutter (OOO until 2018) 2016/01/21 00:58:38 count() doesn't make sense outside of UseCounter,
nainar 2016/01/21 02:39:07 Done.
41 { 50 {
51 ASSERT(propertyID >= CSSPropertyInvalid);
alancutter (OOO until 2018) 2016/01/21 00:58:38 Why is CSSPropertyInvalid a valid propertyID?
nainar 2016/01/21 02:39:07 Fixed.
52 ASSERT(propertyID <= lastUnresolvedCSSProperty);
53 m_CSSPropertyDeprecationBits.quickSet(propertyID);
42 } 54 }
55 bool isCounted(CSSPropertyID propertyID)
56 {
57 ASSERT(propertyID >= CSSPropertyInvalid);
58 ASSERT(propertyID <= lastUnresolvedCSSProperty);
59 return m_CSSPropertyDeprecationBits.quickGet(propertyID);
60 }
61 static void showDeprecationWarning(const LocalFrame*, CSSPropertyID);
62 // CSSPropertyIDs that aren't deprecated return an empty string.
63 static String deprecationMessage(CSSPropertyID);
43 64
44 // When adding members, CrossThreadFetchInitiatorInfoData should be 65 protected:
45 // updated. 66 BitVector m_CSSPropertyDeprecationBits;
46 AtomicString name;
47 TextPosition position;
48 double startTime;
49 };
50
51 // Encode AtomicString as String to cross threads.
52 struct CrossThreadFetchInitiatorInfoData {
53 DISALLOW_NEW();
54 explicit CrossThreadFetchInitiatorInfoData(const FetchInitiatorInfo& info)
55 : name(info.name.string().isolatedCopy())
56 , position(info.position)
57 , startTime(info.startTime)
58 {
59 }
60
61 operator FetchInitiatorInfo() const
62 {
63 FetchInitiatorInfo info;
64 info.name = AtomicString(name);
65 info.position = position;
66 info.startTime = startTime;
67 return info;
68 }
69
70 String name;
71 TextPosition position;
72 double startTime;
73 }; 67 };
74 68
75 } // namespace blink 69 } // namespace blink
76 70
77 #endif 71 #endif // DeprecationHelper_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698