content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java - Issue 1584993002: Delete code involving overdraw bottom height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/compositor_view.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

index 6ebab15651732488b5f1e4255ad2bbf54e67365b..95c0b36169134710e3b054d76cf94a9ac09215b9 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

@@ -46,11 +46,9 @@ public class ContentViewClient {

* Notifies the client that the position of the top controls has changed.

* @param topControlsOffsetYPix The Y offset of the top controls in physical pixels.

* @param contentOffsetYPix The Y offset of the content in physical pixels.

- * @param overdrawBottomHeightPix The overdraw height.

public void onOffsetsForFullscreenChanged(

- float topControlsOffsetYPix, float contentOffsetYPix, float overdrawBottomHeightPix) {

- }

+ float topControlsOffsetYPix, float contentOffsetYPix) { }

public boolean shouldOverrideKeyEvent(KeyEvent event) {

int keyCode = event.getKeyCode();