Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.content.ActivityNotFoundException; 7 import android.content.ActivityNotFoundException;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.view.KeyEvent; 10 import android.view.KeyEvent;
(...skipping 28 matching lines...) Expand all
39 * Called whenever the background color of the page changes as notified by W ebKit. 39 * Called whenever the background color of the page changes as notified by W ebKit.
40 * @param color The new ARGB color of the page background. 40 * @param color The new ARGB color of the page background.
41 */ 41 */
42 public void onBackgroundColorChanged(int color) { 42 public void onBackgroundColorChanged(int color) {
43 } 43 }
44 44
45 /** 45 /**
46 * Notifies the client that the position of the top controls has changed. 46 * Notifies the client that the position of the top controls has changed.
47 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels. 47 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels.
48 * @param contentOffsetYPix The Y offset of the content in physical pixels. 48 * @param contentOffsetYPix The Y offset of the content in physical pixels.
49 * @param overdrawBottomHeightPix The overdraw height.
50 */ 49 */
51 public void onOffsetsForFullscreenChanged( 50 public void onOffsetsForFullscreenChanged(
52 float topControlsOffsetYPix, float contentOffsetYPix, float overdraw BottomHeightPix) { 51 float topControlsOffsetYPix, float contentOffsetYPix) { }
53 }
54 52
55 public boolean shouldOverrideKeyEvent(KeyEvent event) { 53 public boolean shouldOverrideKeyEvent(KeyEvent event) {
56 int keyCode = event.getKeyCode(); 54 int keyCode = event.getKeyCode();
57 55
58 if (!shouldPropagateKey(keyCode)) return true; 56 if (!shouldPropagateKey(keyCode)) return true;
59 57
60 return false; 58 return false;
61 } 59 }
62 60
63 /** 61 /**
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 * ContentViewClient users can return a custom value to override the height of 207 * ContentViewClient users can return a custom value to override the height of
210 * the ContentView. By default, this method returns MeasureSpec.UNSPECIFIED, which 208 * the ContentView. By default, this method returns MeasureSpec.UNSPECIFIED, which
211 * indicates that the value should not be overridden. 209 * indicates that the value should not be overridden.
212 * 210 *
213 * @return The desired height of the ContentView. 211 * @return The desired height of the ContentView.
214 */ 212 */
215 public int getDesiredHeightMeasureSpec() { 213 public int getDesiredHeightMeasureSpec() {
216 return UNSPECIFIED_MEASURE_SPEC; 214 return UNSPECIFIED_MEASURE_SPEC;
217 } 215 }
218 } 216 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698