Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index b7bbcf4a397e658a310bdee6820141c556d4b7cd..1c62bd45acc9b8788dcdbd8778d16c6c43cde666 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1055,17 +1055,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
return mPhysicalBackingHeightPix;
}
- /* TODO(aelias): Remove these when downstream callers disappear. */
- @VisibleForTesting
- public int getViewportSizeOffsetWidthPix() {
- return 0;
- }
-
- @VisibleForTesting
- public int getViewportSizeOffsetHeightPix() {
- return mTopControlsShrinkBlinkSize ? mTopControlsHeightPix : 0;
- }
-
/**
* @return The amount that the viewport size given to Blink is shrunk by the URL-bar..
*/
@@ -2379,7 +2368,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen
final float controlsOffsetPix = controlsOffsetYCss * deviceScale;
// TODO(aelias): Remove last argument after downstream removes it.
getContentViewClient().onOffsetsForFullscreenChanged(
- controlsOffsetPix, contentOffsetYPix, 0);
+ controlsOffsetPix, contentOffsetYPix);
if (mBrowserAccessibilityManager != null) {
mBrowserAccessibilityManager.notifyFrameInfoInitialized();
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698