Improvement handling of background and outline paint phases

Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938
Committed: https://crrev.com/7cbfbcef3ed11feafc3f77c0225b73008abb6d85
Cr-Commit-Position: refs/heads/master@{#369657}

[Xianzhu, 2016-01-13 21:58:40]

Description was changed from

==========
Improvement about background and outline paint phases
==========

to

==========
Improvement handling of background and outline paint phases
==========

[Xianzhu, 2016-01-13 22:05:08]

Description was changed from

==========
Improvement handling of background and outline paint phases
==========

to

==========
Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938
==========

[Xianzhu, 2016-01-13 22:05:23]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[Xianzhu, 2016-01-14 01:04:33]

The BlockPainter part has a bug. Fixing.

[Xianzhu, 2016-01-14 01:15:25]

On 2016/01/14 01:04:33, Xianzhu wrote:
> The BlockPainter part has a bug. Fixing.

Done.

[pdr., 2016-01-14 19:51:50]

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPainter.cpp:537: if (paintInfo.phase
== PaintPhaseSelection || paintInfo.phase == PaintPhaseTextClip) {
Can you add a comment here about why we preserve the phase for selection and
text clip?

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/TablePainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/TablePainter.cpp:25: if
(m_layoutTable.hasBoxDecorationBackground() &&
m_layoutTable.style()->visibility() == VISIBLE)
Can this check be moved into paintBoxDecorationBackground?

[pdr., 2016-01-14 19:56:45]

LGTM

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintPhase.h (right):

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintPhase.h:92: return phase ==
PaintPhaseBlockBackground || phase == PaintPhaseSelfBlockBackgroundOnly;
(not for this patch) We might want to consider using a mask here for
performance, instead of two conditionals.

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:46: 
else?

[Xianzhu, 2016-01-15 00:43:28]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-01-15 00:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1584903002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-01-15 00:46:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584903002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584903002/120001

[Xianzhu, 2016-01-15 01:05:33]

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ObjectPainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ObjectPainter.cpp:537: if (paintInfo.phase
== PaintPhaseSelection || paintInfo.phase == PaintPhaseTextClip) {
On 2016/01/14 19:51:50, pdr wrote:
> Can you add a comment here about why we preserve the phase for selection and
> text clip?

Done.

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/TablePainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/TablePainter.cpp:25: if
(m_layoutTable.hasBoxDecorationBackground() &&
m_layoutTable.style()->visibility() == VISIBLE)
On 2016/01/14 19:51:50, pdr wrote:
> Can this check be moved into paintBoxDecorationBackground?

Done.

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintPhase.h (right):

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintPhase.h:92: return phase ==
PaintPhaseBlockBackground || phase == PaintPhaseSelfBlockBackgroundOnly;
On 2016/01/14 19:56:45, pdr wrote:
> (not for this patch) We might want to consider using a mask here for
> performance, instead of two conditionals.

Thought of this but it will cause difficulties to synchronize between PaintPhase
and DisplayItem::Type. Perhaps we should consider to move PaintPhase.h to
Source/platform/graphics/paint?

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/TableSectionPainter.cpp (right):

https://codereview.chromium.org/1584903002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/TableSectionPainter.cpp:46: 
On 2016/01/14 19:56:45, pdr wrote:
> else?

No. PaintPhaseOutline needs to execute both the above and the below blocks.

[pdr., 2016-01-15 01:48:48]

Lgtm

[commit-bot: I haz the power, 2016-01-15 02:14:12]

Description was changed from

==========
Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938
==========

to

==========
Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938
==========

[commit-bot: I haz the power, 2016-01-15 02:14:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-15 02:15:34]

Description was changed from

==========
Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938
==========

to

==========
Improvement handling of background and outline paint phases

- Add 'Only' postfix to PaintPhaseSelfBlockBackground
  PaintPhaseDescendantBlockBackgrounds, PaintPhaseSelfOutline
  and PaintPhaseDescendantOutlines;

- Add shouldPaintSelfBlockBackground(), shouldPaintSelfOutline(),
  shouldPaintDescendantBlockBackgrounds(),
  shouldPaintDescendantOutlines();

- Use PaintInfo::forDescendants();

- Fix improper handling of the paint phases in TablePainter,
  TableSectionPainter and TableRowPainter. Previously they paint
  descendant outlines in PaintPhaseSelfOutlineOnly and ignore
  PaintPhaseDescendantOutlinesOnly.

- Add checks/early returns for PaintPhaseSelfBlockBackgroundOnly
  and PaintPhaseSelfOutlineOnly to avoid execution of unnecessary
  code.

BUG=574938

Committed: https://crrev.com/7cbfbcef3ed11feafc3f77c0225b73008abb6d85
Cr-Commit-Position: refs/heads/master@{#369657}
==========

[commit-bot: I haz the power, 2016-01-15 02:15:36]

Patchset 7 (id:??) landed as
https://crrev.com/7cbfbcef3ed11feafc3f77c0225b73008abb6d85
Cr-Commit-Position: refs/heads/master@{#369657}