third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp - Issue 1584903002: Improvement handling of background and outline paint phases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

Issue 1584903002: Improvement handling of background and outline paint phases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintPhaseRename

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

index c6d091fa6b3eb31cdfc9bc89f96d465f5e25ff08..9e4285f8eb9d4f3b1f6e1777e85fc8869d60b7ae 100644

--- a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

@@ -65,25 +65,25 @@ TEST_F(LayoutObjectDrawingRecorderTest, Cached)

rootPaintController().invalidateAll();

GraphicsContext context(rootPaintController());

LayoutRect bound = layoutView().viewRect();

- drawNothing(context, layoutView(), PaintPhaseSelfBlockBackground, bound);

+ drawNothing(context, layoutView(), PaintPhaseSelfBlockBackgroundOnly, bound);

drawRect(context, layoutView(), PaintPhaseForeground, bound);

rootPaintController().commitNewDisplayItems();

EXPECT_DISPLAY_LIST(rootPaintController().displayItemList(), 2,

- TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackground)),

+ TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackgroundOnly)),

TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground)));

- drawNothing(context, layoutView(), PaintPhaseSelfBlockBackground, bound);

+ drawNothing(context, layoutView(), PaintPhaseSelfBlockBackgroundOnly, bound);

drawRect(context, layoutView(), PaintPhaseForeground, bound);

EXPECT_DISPLAY_LIST(rootPaintController().newDisplayItemList(), 2,

- TestDisplayItem(layoutView(), DisplayItem::drawingTypeToCachedDrawingType(DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackground))),

+ TestDisplayItem(layoutView(), DisplayItem::drawingTypeToCachedDrawingType(DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackgroundOnly))),

TestDisplayItem(layoutView(), DisplayItem::drawingTypeToCachedDrawingType(DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground))));

rootPaintController().commitNewDisplayItems();

EXPECT_DISPLAY_LIST(rootPaintController().displayItemList(), 2,

- TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackground)),

+ TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackgroundOnly)),

TestDisplayItem(layoutView(), DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground)));

}