Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintInfo.h

Issue 1584903002: Improvement handling of background and outline paint phases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintPhaseRename
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 , m_paintFlags(copyOtherFieldsFrom.m_paintFlags) 72 , m_paintFlags(copyOtherFieldsFrom.m_paintFlags)
73 , m_globalPaintFlags(copyOtherFieldsFrom.m_globalPaintFlags) 73 , m_globalPaintFlags(copyOtherFieldsFrom.m_globalPaintFlags)
74 { } 74 { }
75 75
76 // Creates a PaintInfo for painting descendants. See comments about the pain t phases 76 // Creates a PaintInfo for painting descendants. See comments about the pain t phases
77 // in PaintPhase.h for details. 77 // in PaintPhase.h for details.
78 // TODO(wangxianzhu): Actually use this method. 78 // TODO(wangxianzhu): Actually use this method.
79 PaintInfo forDescendants() const 79 PaintInfo forDescendants() const
80 { 80 {
81 PaintInfo result(*this); 81 PaintInfo result(*this);
82 if (phase == PaintPhaseDescendantOutlines) 82 if (phase == PaintPhaseDescendantOutlinesOnly)
83 result.phase = PaintPhaseOutline; 83 result.phase = PaintPhaseOutline;
84 else if (phase == PaintPhaseDescendantBlockBackgrounds) 84 else if (phase == PaintPhaseDescendantBlockBackgroundsOnly)
85 result.phase = PaintPhaseBlockBackground; 85 result.phase = PaintPhaseBlockBackground;
86 return result; 86 return result;
87 } 87 }
88 88
89 void updatePaintingRootForChildren(const LayoutObject*); 89 void updatePaintingRootForChildren(const LayoutObject*);
90 90
91 bool shouldPaintWithinRoot(const LayoutObject*) const; 91 bool shouldPaintWithinRoot(const LayoutObject*) const;
92 92
93 bool isRenderingClipPathAsMaskImage() const { return m_paintFlags & PaintLay erPaintingRenderingClipPathAsMask; } 93 bool isRenderingClipPathAsMaskImage() const { return m_paintFlags & PaintLay erPaintingRenderingClipPathAsMask; }
94 94
(...skipping 27 matching lines...) Expand all
122 const GlobalPaintFlags m_globalPaintFlags; 122 const GlobalPaintFlags m_globalPaintFlags;
123 123
124 // TODO(chrishtr): temporary while we implement CullRect everywhere. 124 // TODO(chrishtr): temporary while we implement CullRect everywhere.
125 friend class SVGPaintContext; 125 friend class SVGPaintContext;
126 friend class SVGShapePainter; 126 friend class SVGShapePainter;
127 }; 127 };
128 128
129 } // namespace blink 129 } // namespace blink
130 130
131 #endif // PaintInfo_h 131 #endif // PaintInfo_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInfoTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698