Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584703003: Remove two varieties of drawNonAARect from GrDrawTarget (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@hidedrawtargetabit
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : deprecation message on GrTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -136 lines) Patch
M gm/bigrrectaaeffect.cpp View 4 chunks +15 lines, -12 lines 0 comments Download
M gm/constcolorprocessor.cpp View 4 chunks +14 lines, -13 lines 0 comments Download
M gm/rrects.cpp View 4 chunks +12 lines, -11 lines 0 comments Download
M gm/texturedomaineffect.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 3 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 5 chunks +27 lines, -35 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 3 chunks +16 lines, -4 lines 0 comments Download
M src/gpu/GrTest.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1574383002 Patch 80001

Messages

Total messages: 9 (4 generated)
joshualitt
I personally think this is an improvement, but I'll wait to remove the rest of ...
4 years, 11 months ago (2016-01-13 16:46:05 UTC) #3
bsalomon
lgtm
4 years, 11 months ago (2016-01-13 17:34:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584703003/20001
4 years, 11 months ago (2016-01-13 17:55:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/04194f32f4f5ec9029357a18c0f1f9dc3404fc0c
4 years, 11 months ago (2016-01-13 18:08:30 UTC) #8
robertphillips
4 years, 11 months ago (2016-01-13 18:36:12 UTC) #9
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698