Hide drawBatch on GrDrawTarget from test Methods

Hide drawBatch on GrDrawTarget from test Methods

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1574383002

Committed: https://skia.googlesource.com/skia/+/f5883a6d75a18c581507214d3057b5c721ed1ffc

[joshua.litt, 2016-01-12 20:06:43]

Description was changed from

==========
Hide drawBatch on GrDrawTarget from test Methods

BUG=skia:
==========

to

==========
Hide drawBatch on GrDrawTarget from test Methods

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-12 20:46:44]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[robertphillips, 2016-01-12 20:56:33]

https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp
File gm/convexpolyeffect.cpp (right):

https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp...
gm/convexpolyeffect.cpp:35: struct Geometry : public GrTestBatch::Geometry {
Why do we need fRect ?

https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp
File src/gpu/GrTest.cpp (right):

https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp#newc...
src/gpu/GrTest.cpp:262: SkDEBUGCODE(this->validate();)
I think we still want to get a test target in here 

If we do need to, can we pass a const ref of the pipelineBuilder ?

[joshualitt, 2016-01-12 21:37:33]

On 2016/01/12 20:56:33, robertphillips wrote:
> https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp
> File gm/convexpolyeffect.cpp (right):
> 
>
https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp...
> gm/convexpolyeffect.cpp:35: struct Geometry : public GrTestBatch::Geometry {
> Why do we need fRect ?
Because one of the rects is inverted and can't be used as bounds.
> 
> https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp
> File src/gpu/GrTest.cpp (right):
> 
>
https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp#newc...
> src/gpu/GrTest.cpp:262: SkDEBUGCODE(this->validate();)
> I think we still want to get a test target in here 
After talking it over with Robert, I don't think we need a test target.
> 
> If we do need to, can we pass a const ref of the pipelineBuilder ?

Done

[joshualitt, 2016-01-12 21:42:54]

On 2016/01/12 21:37:33, joshualitt wrote:
> On 2016/01/12 20:56:33, robertphillips wrote:
> >
https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp
> > File gm/convexpolyeffect.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1574383002/diff/20001/gm/convexpolyeffect.cpp...
> > gm/convexpolyeffect.cpp:35: struct Geometry : public GrTestBatch::Geometry {
> > Why do we need fRect ?
> Because one of the rects is inverted and can't be used as bounds.
> > 
> > https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp
> > File src/gpu/GrTest.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1574383002/diff/20001/src/gpu/GrTest.cpp#newc...
> > src/gpu/GrTest.cpp:262: SkDEBUGCODE(this->validate();)
> > I think we still want to get a test target in here 
> After talking it over with Robert, I don't think we need a test target.
> > 
> > If we do need to, can we pass a const ref of the pipelineBuilder ?
> 
> Done

comment added

[robertphillips, 2016-01-12 21:51:04]

lgtm

[bsalomon, 2016-01-13 14:05:15]

Aren't these ref counted? Don't we need a null check? Doc on
GrContext::drawContext() says it returns null if the GrContext is abandoned.

[joshualitt, 2016-01-13 14:50:10]

On 2016/01/13 14:05:15, bsalomon wrote:
> Aren't these ref counted? Don't we need a null check? Doc on
> GrContext::drawContext() says it returns null if the GrContext is abandoned.

feedback incorporated

[joshualitt, 2016-01-13 15:26:49]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-01-13 15:26:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1574383002/#ps80001
(title: "tweaks")

[commit-bot: I haz the power, 2016-01-13 15:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1574383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1574383002/80001

[commit-bot: I haz the power, 2016-01-13 15:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 15:28:00]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[joshualitt, 2016-01-13 15:46:44]

Description was changed from

==========
Hide drawBatch on GrDrawTarget from test Methods

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Hide drawBatch on GrDrawTarget from test Methods

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-01-13 15:46:53]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-01-13 15:47:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1574383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1574383002/80001

[commit-bot: I haz the power, 2016-01-13 15:47:41]

Description was changed from

==========
Hide drawBatch on GrDrawTarget from test Methods

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Hide drawBatch on GrDrawTarget from test Methods

TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/f5883a6d75a18c581507214d3057b5c721ed1ffc
==========

[commit-bot: I haz the power, 2016-01-13 15:47:42]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f5883a6d75a18c581507214d3057b5c721ed1ffc