Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584473002: Swizzle shader output and blend when using GL_RED to implement kAlpha_8_GrPixelConfig (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@hideformats
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Swizzle shader output and blend when using GL_RED to implement kAlpha_8_GrPixelConfig GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1584473002 Committed: https://skia.googlesource.com/skia/+/7f9b2e4a45775e8cdd3f98260a66c0c6e1840550

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : cleanup #

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -44 lines) Patch
M gyp/gpu.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/GrSwizzle.h View 1 2 3 4 chunks +48 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 8 chunks +27 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 5 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 1 2 chunks +7 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1580003002 Patch 80001

Dependent Patchsets:

Issue 1584563002 Patch 1

Messages

Total messages: 10 (4 generated)
bsalomon
4 years, 11 months ago (2016-01-12 17:50:52 UTC) #3
egdaniel
https://codereview.chromium.org/1584473002/diff/20001/gyp/gpu.gypi File gyp/gpu.gypi (right): https://codereview.chromium.org/1584473002/diff/20001/gyp/gpu.gypi#newcode178 gyp/gpu.gypi:178: '<(skia_src_path)/gpu/GrSwizzle.h', tabbed https://codereview.chromium.org/1584473002/diff/20001/src/gpu/GrSwizzle.h File src/gpu/GrSwizzle.h (right): https://codereview.chromium.org/1584473002/diff/20001/src/gpu/GrSwizzle.h#newcode111 src/gpu/GrSwizzle.h:111: 'a'; ...
4 years, 11 months ago (2016-01-12 20:13:55 UTC) #4
bsalomon
PTAL, comments addressed and added emitFSOutputSwizzle to GrGLProgramBuilder. https://codereview.chromium.org/1584473002/diff/20001/gyp/gpu.gypi File gyp/gpu.gypi (right): https://codereview.chromium.org/1584473002/diff/20001/gyp/gpu.gypi#newcode178 gyp/gpu.gypi:178: '<(skia_src_path)/gpu/GrSwizzle.h', ...
4 years, 11 months ago (2016-01-12 20:33:55 UTC) #5
egdaniel
lgtm
4 years, 11 months ago (2016-01-12 21:03:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584473002/60001
4 years, 11 months ago (2016-01-12 21:12:03 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 21:29:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7f9b2e4a45775e8cdd3f98260a66c0c6e1840550

Powered by Google App Engine
This is Rietveld 408576698