Hide formats in GrGLCaps and use specific getters for different GL functions.

Hide formats in GrGLCaps and use specific getters for different GL functions.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1580003002

Committed: https://skia.googlesource.com/skia/+/76148af6df1f8da67cbed13b4d8216b36a41b3dd

[bsalomon, 2016-01-12 15:37:49]

Description was changed from

==========
Hide formats in GrGLCaps and use specific getters for different GL functions.
==========

to

==========
Hide formats in GrGLCaps and use specific getters for different GL functions.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-12 15:58:23]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2016-01-12 15:58:24]

Gives me some hooks for doing alpha readbacks from BGRA/RGBA rendertargets.

[egdaniel, 2016-01-12 18:30:38]

lgtm + nit

https://codereview.chromium.org/1580003002/diff/60001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1580003002/diff/60001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:1525:
fConfigTable[kSRGBA_8888_GrPixelConfig].fFormats.fExternalFormat[kTexImage_ExternalFormatUsage]
=
hmmm over 100, but no great breaking point...

[bsalomon, 2016-01-12 19:00:53]

https://codereview.chromium.org/1580003002/diff/60001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1580003002/diff/60001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:1525:
fConfigTable[kSRGBA_8888_GrPixelConfig].fFormats.fExternalFormat[kTexImage_ExternalFormatUsage]
=
On 2016/01/12 18:30:38, egdaniel wrote:
> hmmm over 100, but no great breaking point...

yep, wasn't sure what to do with that one, so I left it.

[bsalomon, 2016-01-12 19:00:56]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-12 19:02:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580003002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580003002/80001

[commit-bot: I haz the power, 2016-01-12 19:13:49]

Description was changed from

==========
Hide formats in GrGLCaps and use specific getters for different GL functions.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Hide formats in GrGLCaps and use specific getters for different GL functions.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/76148af6df1f8da67cbed13b4d8216b36a41b3dd
==========

[commit-bot: I haz the power, 2016-01-12 19:13:50]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/76148af6df1f8da67cbed13b4d8216b36a41b3dd