Make A8 readback work in more cases and improve testing.

Make A8 readback work in more cases and improve testing.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1584563002

Committed: https://skia.googlesource.com/skia/+/b76afedf11c7fe933954d030048c3222860249e1

[bsalomon, 2016-01-12 21:17:33]

Description was changed from

==========
Make A8 readback work in more cases and improve testing.

BUG=skia:
==========

to

==========
Make A8 readback work in more cases and improve testing.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-13 14:06:34]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2016-01-13 19:51:41]

On 2016/01/13 14:06:35, bsalomon wrote:

ping

[egdaniel, 2016-01-13 19:58:18]

lgtm

https://codereview.chromium.org/1584563002/diff/70001/tests/ReadWriteAlphaTes...
File tests/ReadWriteAlphaTest.cpp (right):

https://codereview.chromium.org/1584563002/diff/70001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:42: ERRORF(reporter, "Could not create alpha
texture.");
just to confirm this check here. We are requiring we can create a non-RT alpha
texture, but we're fine if a RT one fails. right?

[bsalomon, 2016-01-13 20:04:03]

https://codereview.chromium.org/1584563002/diff/70001/tests/ReadWriteAlphaTes...
File tests/ReadWriteAlphaTest.cpp (right):

https://codereview.chromium.org/1584563002/diff/70001/tests/ReadWriteAlphaTes...
tests/ReadWriteAlphaTest.cpp:42: ERRORF(reporter, "Could not create alpha
texture.");
On 2016/01/13 19:58:18, egdaniel wrote:
> just to confirm this check here. We are requiring we can create a non-RT alpha
> texture, but we're fine if a RT one fails. right?

That's correct. Some drivers do not render to either GL_ALPHA8 textures and lack
GL_R8 textures.

[bsalomon, 2016-01-13 20:04:05]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-13 20:04:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584563002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584563002/70001

[commit-bot: I haz the power, 2016-01-13 20:19:17]

Description was changed from

==========
Make A8 readback work in more cases and improve testing.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make A8 readback work in more cases and improve testing.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b76afedf11c7fe933954d030048c3222860249e1
==========

[commit-bot: I haz the power, 2016-01-13 20:19:18]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/b76afedf11c7fe933954d030048c3222860249e1

[bsalomon, 2016-01-14 15:19:29]

A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/1581203005/ by bsalomon@google.com.

The reason for reverting is: Breaking video tests in Chrome..