Make android scripts not warn about ADB in newer SDKs

Make android scripts not warn about ADB in newer SDKs

The older SDK says:
$ adb version
Android Debug Bridge version 1.0.32

The newer SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583793002

Committed: https://skia.googlesource.com/skia/+/7ddfeeddf78b78de28874432eb9a95735b56af7b

[Kimmo Kinnunen, 2016-01-13 13:14:21]

Description was changed from

==========
Make android scripts not warn about ADB in newer SDKs

Updated SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
==========

to

==========
Make android scripts not warn about ADB in newer SDKs

Updated SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-01-13 13:14:49]

kkinnunen@nvidia.com changed reviewers:
+ djsollen@google.com

[Kimmo Kinnunen, 2016-01-13 13:14:50]

Feel free to repost with a different parsing strategy.

[djsollen, 2016-01-13 14:32:04]

https://codereview.chromium.org/1583793002/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/utils/setup_adb.sh (right):

https://codereview.chromium.org/1583793002/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/utils/setup_adb.sh:32: ADB_VERSION=${ADB_VERSION[4]}
I think this will break backwards compatibility for people who have older
versions.  I think breaking it into an array is a good idea, but we should pull
from the last entry into the array and not 4.  How about trying...

ADB_VER_SIZE=${#ADB_VERSION[@]}
ADB_VERSION_=${ADB_VERSION[ADB_VER_SIZE - 1]}

[Kimmo Kinnunen, 2016-01-13 15:15:51]

Description was changed from

==========
Make android scripts not warn about ADB in newer SDKs

Updated SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make android scripts not warn about ADB in newer SDKs

The older SDK says:
$ adb version
Android Debug Bridge version 1.0.32

The newer SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-01-13 15:19:50]

I have not tried your suggestion yet, I can do it tomorrow -- just clarifying.

https://codereview.chromium.org/1583793002/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/utils/setup_adb.sh (right):

https://codereview.chromium.org/1583793002/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/utils/setup_adb.sh:32: ADB_VERSION=${ADB_VERSION[4]}
On 2016/01/13 14:32:04, djsollen wrote:
> I think this will break backwards compatibility for people who have older
> versions.  I think breaking it into an array is a good idea, but we should
pull
> from the last entry into the array and not 4.  How about trying...
> 
> ADB_VER_SIZE=${#ADB_VERSION[@]}
> ADB_VERSION_=${ADB_VERSION[ADB_VER_SIZE - 1]}
The intention is exactly getting the 5th element. It works with the old string
and the new string. 

The last element of the new string is not the version -- that is the original
bug. 

Or maybe you mean something even older than what I've seen?
E.g. I've seen the ones in the commit msg

[djsollen, 2016-01-13 15:28:13]

There used to be on that included only the version, but I haven't seen that for
some time so I'm happy to remove support for it.  So as it stands this CL lgtm.

[Kimmo Kinnunen, 2016-01-14 06:42:00]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-01-14 06:42:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583793002/1

[commit-bot: I haz the power, 2016-01-14 06:53:58]

Description was changed from

==========
Make android scripts not warn about ADB in newer SDKs

The older SDK says:
$ adb version
Android Debug Bridge version 1.0.32

The newer SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make android scripts not warn about ADB in newer SDKs

The older SDK says:
$ adb version
Android Debug Bridge version 1.0.32

The newer SDK says:
$ adb version
Android Debug Bridge version 1.0.32
Revision eac51f2bb6a8-android

Removes the shebang as the file is not intended to be
run, and the copyright would render it useless.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7ddfeeddf78b78de28874432eb9a95735b56af7b
==========

[commit-bot: I haz the power, 2016-01-14 06:53:58]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ddfeeddf78b78de28874432eb9a95735b56af7b