Make android scripts not warn about ADB in newer SDKs

platform_tools/android/bin/utils/setup_adb.sh

-#!/bin/bash
+# Copyright 2015 Google Inc.
 #
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
 
 UTIL_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 if [ "$(which adb)" != "" ]; then
     ADB="$(which adb)"
 elif [ -d "$ANDROID_SDK_ROOT" ]; then
     ADB="${ANDROID_SDK_ROOT}/platform-tools/adb"
 else
   echo $ANDROID_SDK_ROOT
   echo "No ANDROID_SDK_ROOT set (check that android_setup.sh was properly sourced)"
   exit 1
 fi
 
 if [ ! -x $ADB ]; then
   echo "The adb binary is not executable"
   exit 1
 fi
 
 if [ $(uname) == "Linux" ]; then
   ADB_REQUIRED="1.0.32"
 elif [ $(uname) == "Darwin" ]; then
   ADB_REQUIRED="1.0.31 or 1.0.32"
 fi
 
-# get the version and then truncate it to be just the version numbers
+# get the version string as an array, use just the version numbers
 ADB_VERSION="$($ADB version)"
-ADB_VERSION="${ADB_VERSION##* }"
+ADB_VERSION=($ADB_VERSION)
+ADB_VERSION=${ADB_VERSION[4]}

[djsollen, 2016/01/13 14:32:04]

I think this will break backwards compatibility for people who have older
versions.  I think breaking it into an array is a good idea, but we should pull
from the last entry into the array and not 4.  How about trying...

ADB_VER_SIZE=${#ADB_VERSION[@]}
ADB_VERSION_=${ADB_VERSION[ADB_VER_SIZE - 1]}

[Kimmo Kinnunen, 2016/01/13 15:19:50]

The intention is exactly getting the 5th element. It works with the old string
and the new string. 

The last element of the new string is not the version -- that is the original
bug. 

Or maybe you mean something even older than what I've seen?
E.g. I've seen the ones in the commit msg

 
 if [[ "$ADB_REQUIRED" != *"$ADB_VERSION"* ]]; then
   echo "WARNING: Your ADB version is out of date!"
   echo "  Expected ADB Version: ${ADB_REQUIRED}"
   echo "  Actual ADB Version: ${ADB_VERSION}"
 fi