Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 1582533005: MIPS64: Fix 'MIPS: Fix dd() implementations for compact branches.' (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'MIPS: Fix dd() implementations for compact branches.' Port 5091e8f2f5d83a7061e88bb0ef2399e4b042ae0d TEST=cctest/test-assembler-mips64/jump_tables1,cctest/test-assembler-mips64/jump_tables2,cctest/test-assembler-mips64/jump_tables3,cctest/test-macro-assembler-mips/jump_tables5 BUG= Committed: https://crrev.com/0830ac7cc303e09940a474dab50944c114732afc Cr-Commit-Position: refs/heads/master@{#33266}

Patch Set 1 #

Patch Set 2 : Fix jump_tables5. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M test/cctest/test-assembler-mips64.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
balazs.kilvady
I reduced the number of instructions in jump_tables[1|2|3] tests to keep Align() for Ivica. The ...
4 years, 11 months ago (2016-01-13 11:23:02 UTC) #2
akos.palfi.imgtec
lgtm
4 years, 11 months ago (2016-01-13 12:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582533005/1
4 years, 11 months ago (2016-01-13 12:52:23 UTC) #5
balazs.kilvady
I fixed the jump_tables5 tests and updated the description.
4 years, 11 months ago (2016-01-13 13:38:20 UTC) #9
paul.l...
lgtm
4 years, 11 months ago (2016-01-13 13:55:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582533005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582533005/40001
4 years, 11 months ago (2016-01-13 13:56:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-13 15:15:32 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 15:16:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0830ac7cc303e09940a474dab50944c114732afc
Cr-Commit-Position: refs/heads/master@{#33266}

Powered by Google App Engine
This is Rietveld 408576698