Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: test/cctest/test-assembler-mips64.cc

Issue 1582533005: MIPS64: Fix 'MIPS: Fix dd() implementations for compact branches.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix jump_tables5. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-macro-assembler-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-assembler-mips64.cc
diff --git a/test/cctest/test-assembler-mips64.cc b/test/cctest/test-assembler-mips64.cc
index 5e8ed089bf668d4b250a781e1af6c7b7e91bf71e..988083cadc0247c799d19cfc67ed70d357f27eb4 100644
--- a/test/cctest/test-assembler-mips64.cc
+++ b/test/cctest/test-assembler-mips64.cc
@@ -3226,17 +3226,16 @@ TEST(jump_tables1) {
Label done;
{
- __ BlockTrampolinePoolFor(kNumCases * 2 + 7);
+ __ BlockTrampolinePoolFor(kNumCases * 2 + 6);
PredictableCodeSizeScope predictable(
- &assm, (kNumCases * 2 + 7) * Assembler::kInstrSize);
+ &assm, (kNumCases * 2 + 6) * Assembler::kInstrSize);
Label here;
__ bal(&here);
- __ nop();
+ __ dsll(at, a0, 3); // In delay slot.
__ bind(&here);
- __ dsll(at, a0, 3);
__ daddu(at, at, ra);
- __ ld(at, MemOperand(at, 5 * Assembler::kInstrSize));
+ __ ld(at, MemOperand(at, 4 * Assembler::kInstrSize));
__ jr(at);
__ nop();
for (int i = 0; i < kNumCases; ++i) {
@@ -3305,17 +3304,16 @@ TEST(jump_tables2) {
__ Align(8);
__ bind(&dispatch);
{
- __ BlockTrampolinePoolFor(kNumCases * 2 + 7);
+ __ BlockTrampolinePoolFor(kNumCases * 2 + 6);
PredictableCodeSizeScope predictable(
- &assm, (kNumCases * 2 + 7) * Assembler::kInstrSize);
+ &assm, (kNumCases * 2 + 6) * Assembler::kInstrSize);
Label here;
__ bal(&here);
- __ nop();
+ __ dsll(at, a0, 3); // In delay slot.
__ bind(&here);
- __ dsll(at, a0, 3);
__ daddu(at, at, ra);
- __ ld(at, MemOperand(at, 5 * Assembler::kInstrSize));
+ __ ld(at, MemOperand(at, 4 * Assembler::kInstrSize));
__ jr(at);
__ nop();
for (int i = 0; i < kNumCases; ++i) {
@@ -3386,17 +3384,16 @@ TEST(jump_tables3) {
__ Align(8);
__ bind(&dispatch);
{
- __ BlockTrampolinePoolFor(kNumCases * 2 + 7);
+ __ BlockTrampolinePoolFor(kNumCases * 2 + 6);
PredictableCodeSizeScope predictable(
- &assm, (kNumCases * 2 + 7) * Assembler::kInstrSize);
+ &assm, (kNumCases * 2 + 6) * Assembler::kInstrSize);
Label here;
__ bal(&here);
- __ nop();
+ __ dsll(at, a0, 3); // In delay slot.
__ bind(&here);
- __ dsll(at, a0, 3);
__ daddu(at, at, ra);
- __ ld(at, MemOperand(at, 5 * Assembler::kInstrSize));
+ __ ld(at, MemOperand(at, 4 * Assembler::kInstrSize));
__ jr(at);
__ nop();
for (int i = 0; i < kNumCases; ++i) {
« no previous file with comments | « no previous file | test/cctest/test-macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698