Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: test/cctest/test-macro-assembler-mips64.cc

Issue 1582533005: MIPS64: Fix 'MIPS: Fix dd() implementations for compact branches.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix jump_tables5. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-macro-assembler-mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-macro-assembler-mips64.cc
diff --git a/test/cctest/test-macro-assembler-mips64.cc b/test/cctest/test-macro-assembler-mips64.cc
index 05a9b90d60d4950adccae7793ba8dfae301ba4bf..684b554236c123d3c3083fda744a7454a6b0f8e8 100644
--- a/test/cctest/test-macro-assembler-mips64.cc
+++ b/test/cctest/test-macro-assembler-mips64.cc
@@ -341,6 +341,9 @@ TEST(jump_tables5) {
__ jalr(at);
__ nop(); // Branch delay slot nop.
__ bc(&done);
+ // A nop instruction must be generated by the forbidden slot guard
+ // (Assembler::dd(Label*)) so the first label goes to an 8 bytes aligned
+ // location.
for (int i = 0; i < kNumCases; ++i) {
__ dd(&labels[i]);
}
« no previous file with comments | « test/cctest/test-macro-assembler-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698