Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1580683002: Revert of Oilpan: fix build after r368814. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Oilpan: fix build after r368814. (patchset #1 id:1 of https://codereview.chromium.org/1575323002/ ) Reason for revert: Breaks non-Oilpan compilation. Original issue's description: > Oilpan: fix build after r368814. > > TBR=oilpan-reviews > BUG=540528 > NOTRY=true > NOTREECHECKS=true > NOPRESUBMIT=true > > Committed: https://crrev.com/2cf2fab949e741b56be51d1197b064083ec45441 > Cr-Commit-Position: refs/heads/master@{#368817} TBR=oilpan-reviews@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540528 Committed: https://crrev.com/a7a3254c6febcf2321642534f26d150c1b52ec0f Cr-Commit-Position: refs/heads/master@{#368819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sof
Created Revert of Oilpan: fix build after r368814.
4 years, 11 months ago (2016-01-12 08:03:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580683002/1
4 years, 11 months ago (2016-01-12 08:04:26 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-12 08:04:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 08:06:09 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 08:07:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a3254c6febcf2321642534f26d150c1b52ec0f
Cr-Commit-Position: refs/heads/master@{#368819}

Powered by Google App Engine
This is Rietveld 408576698