Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575323002: Oilpan: fix build after r368814. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r368814. TBR=oilpan-reviews BUG=540528 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Committed: https://crrev.com/2cf2fab949e741b56be51d1197b064083ec45441 Cr-Commit-Position: refs/heads/master@{#368817} Committed: https://crrev.com/4d625ae5fa2b9edd9f3c0fa5f1e3da3bb401c9aa Cr-Commit-Position: refs/heads/master@{#368820}

Patch Set 1 #

Patch Set 2 : fix non-Oilpan compilation #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
sof
4 years, 11 months ago (2016-01-12 07:50:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575323002/1
4 years, 11 months ago (2016-01-12 07:52:04 UTC) #3
haraken
LGTM
4 years, 11 months ago (2016-01-12 07:52:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 07:53:02 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2cf2fab949e741b56be51d1197b064083ec45441 Cr-Commit-Position: refs/heads/master@{#368817}
4 years, 11 months ago (2016-01-12 07:53:58 UTC) #7
sof
Aargh, it is wrong in the non-Oilpan case.
4 years, 11 months ago (2016-01-12 08:03:38 UTC) #8
sof
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1580683002/ by sigbjornf@opera.com. ...
4 years, 11 months ago (2016-01-12 08:03:57 UTC) #9
sof
should be ok now, but letting bots cycle through first.
4 years, 11 months ago (2016-01-12 08:07:13 UTC) #11
haraken
LGTM
4 years, 11 months ago (2016-01-12 08:07:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575323002/40001
4 years, 11 months ago (2016-01-12 08:30:21 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 08:35:03 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 08:36:26 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4d625ae5fa2b9edd9f3c0fa5f1e3da3bb401c9aa
Cr-Commit-Position: refs/heads/master@{#368820}

Powered by Google App Engine
This is Rietveld 408576698