Use udev for serial device enumeration on Linux

Use udev for serial device enumeration on Linux

Device enumeration code has been lifted from
src/chrome/browser/extensions/api/serial and moved into src/device/serial.

The enumeration impl for Linux now uses udev to enumerate devices matching the
"tty" subsystem, rather than matching /dev node name patterns.

The Windows implementation remains effectively unchanged, and the Mac
implementation has had its /dev pattern filter relaxed to catch devices of the
more generic forms "/dev/tty.*" and "/dev/cu.*".

BUG=334698
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251218

[Ken Rockot(use gerrit already), 2014-02-10 18:03:28]

Please take a look schieb@ for c/b/e, rpaquay@ for devices/

[scheib, 2014-02-10 23:37:51]

chrome/* lgtm with documentation nit.

https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
File chrome/common/extensions/api/serial.idl (right):

https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
chrome/common/extensions/api/serial.idl:16: // device. Zero otherwise.
Indicate in what Chrome version these become available, or just that they must
be feature detected as they were added later. File an issue to clean up doc
later after API is stable again.

[Ken Rockot(use gerrit already), 2014-02-11 17:51:51]

Thanks. Doc bug filed (http://crbug.com/342827). Notes added to new fields.

[rpaquay, 2014-02-12 00:39:28]

In the previous code, there were some unit tests for matching devices names. Are
those tests not relevant anymore?

https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
File chrome/common/extensions/api/serial.idl (right):

https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
chrome/common/extensions/api/serial.idl:16: // device. Zero otherwise.
On 2014/02/10 23:37:52, scheib wrote:
> Indicate in what Chrome version these become available, or just that they must
> be feature detected as they were added later. File an issue to clean up doc
> later after API is stable again.

Should these fields be optional instead of using default values?

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
File device/serial/serial_device_enumerator.cc (right):

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
device/serial/serial_device_enumerator.cc:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
nit: no "(c)" in copyright notice (same for many files in CL).

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
File device/serial/serial_device_enumerator_mac.cc (right):

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
device/serial/serial_device_enumerator_mac.cc:52: devices->push_back(info);
I am assuming we don't know of any way to retrieve product_name, vendor_id, etc.
in the MacOS implementation. Maybe we could add a "TODO" or create a bug (in
case someone somewhere knows how to do that)?

[Ken Rockot(use gerrit already), 2014-02-12 01:22:44]

Thanks. Regarding the old unit test, I removed it because I don't think it
really adds any worthwhile test coverage. It'd essentially be a convoluted unit
test of base::MatchPattern.

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
File device/serial/serial_device_enumerator.cc (right):

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
device/serial/serial_device_enumerator.cc:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/02/12 00:39:28, rpaquay wrote:
> nit: no "(c)" in copyright notice (same for many files in CL).

Done.

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
File device/serial/serial_device_enumerator_mac.cc (right):

https://codereview.chromium.org/158063002/diff/220001/device/serial/serial_de...
device/serial/serial_device_enumerator_mac.cc:52: devices->push_back(info);
On 2014/02/12 00:39:28, rpaquay wrote:
> I am assuming we don't know of any way to retrieve product_name, vendor_id,
etc.
> in the MacOS implementation. Maybe we could add a "TODO" or create a bug (in
> case someone somewhere knows how to do that)?

Done.

[rpaquay, 2014-02-12 01:59:32]

lgtm with nit:

https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
chrome/common/extensions/api/serial.idl:16: // device. Zero otherwise.
On 2014/02/10 23:37:52, scheib wrote:
> Indicate in what Chrome version these become available, or just that they must
> be feature detected as they were added later. File an issue to clean up doc
> later after API is stable again.

Should these fields be optional instead of using default values?

[Ken Rockot(use gerrit already), 2014-02-12 18:00:43]

On 2014/02/12 01:59:32, rpaquay wrote:
> lgtm with nit:
> 
>
https://codereview.chromium.org/158063002/diff/80001/chrome/common/extensions...
> chrome/common/extensions/api/serial.idl:16: // device. Zero otherwise.
> On 2014/02/10 23:37:52, scheib wrote:
> > Indicate in what Chrome version these become available, or just that they
must
> > be feature detected as they were added later. File an issue to clean up doc
> > later after API is stable again.
> 
> Should these fields be optional instead of using default values?

Doh. Thanks, yes, I somehow missed that. Done.

[Ken Rockot(use gerrit already), 2014-02-12 18:30:52]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-12 18:35:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/158063002/640001

[commit-bot: I haz the power, 2014-02-13 00:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:14:46]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Ken Rockot(use gerrit already), 2014-02-13 06:02:03]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-13 06:02:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/158063002/860001

[commit-bot: I haz the power, 2014-02-13 06:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 06:33:14]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Ken Rockot(use gerrit already), 2014-02-13 18:10:36]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:11:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/158063002/860001

[commit-bot: I haz the power, 2014-02-13 18:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:38:51]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Ken Rockot(use gerrit already), 2014-02-13 20:53:54]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-13 20:56:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/158063002/860001

[commit-bot: I haz the power, 2014-02-13 21:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 21:33:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Ken Rockot(use gerrit already), 2014-02-13 22:33:48]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-13 22:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/158063002/860001

[commit-bot: I haz the power, 2014-02-14 01:17:44]

Change committed as 251218