Use udev for serial device enumeration on Linux

chrome/browser/extensions/api/serial/serial_connection.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/serial/serial_connection.h"
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/platform_file.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/extensions/api/api_resource_manager.h"
-#include "chrome/browser/extensions/api/serial/serial_port_enumerator.h"
 #include "chrome/common/extensions/api/serial.h"
 
 namespace extensions {
 
 namespace {
 
 const int kDefaultBufferSize = 4096;
 
 }
 
@@ skipping 134 matching lines @@
   info->buffer_size = buffer_size_;
   info->receive_timeout = receive_timeout_;
   info->send_timeout = send_timeout_;
   return GetPortInfo(info);
 }
 
 void SerialConnection::StartOpen() {
   DCHECK(!open_complete_.is_null());
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   DCHECK_EQ(file_, base::kInvalidPlatformFileValue);
-  const SerialPortEnumerator::StringSet name_set(
-    SerialPortEnumerator::GenerateValidSerialPortNames());
   base::PlatformFile file = base::kInvalidPlatformFileValue;
-  if (SerialPortEnumerator::DoesPortExist(name_set, port_)) {
-    // It's the responsibility of the API wrapper around SerialConnection to
-    // validate the supplied path against the set of valid port names, and
-    // it is a reasonable assumption that serial port names are ASCII.
-    DCHECK(IsStringASCII(port_));
-    base::FilePath path(
-        base::FilePath::FromUTF8Unsafe(MaybeFixUpPortName(port_)));
-    int flags = base::PLATFORM_FILE_OPEN |
-                base::PLATFORM_FILE_READ |
-                base::PLATFORM_FILE_EXCLUSIVE_READ |
-                base::PLATFORM_FILE_WRITE |
-                base::PLATFORM_FILE_EXCLUSIVE_WRITE |
-                base::PLATFORM_FILE_ASYNC |
-                base::PLATFORM_FILE_TERMINAL_DEVICE;
-    file = base::CreatePlatformFile(path, flags, NULL, NULL);
-  }
+  // It's the responsibility of the API wrapper around SerialConnection to
+  // validate the supplied path against the set of valid port names, and
+  // it is a reasonable assumption that serial port names are ASCII.
+  DCHECK(IsStringASCII(port_));
+  base::FilePath path(
+      base::FilePath::FromUTF8Unsafe(MaybeFixUpPortName(port_)));
+  int flags = base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ |
+              base::PLATFORM_FILE_EXCLUSIVE_READ | base::PLATFORM_FILE_WRITE |
+              base::PLATFORM_FILE_EXCLUSIVE_WRITE | base::PLATFORM_FILE_ASYNC |
+              base::PLATFORM_FILE_TERMINAL_DEVICE;
+  file = base::CreatePlatformFile(path, flags, NULL, NULL);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&SerialConnection::FinishOpen, base::Unretained(this), file));
 }
 
 void SerialConnection::FinishOpen(base::PlatformFile file) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DCHECK(!open_complete_.is_null());
   DCHECK_EQ(file_, base::kInvalidPlatformFileValue);
   OpenCompleteCallback callback = open_complete_;
@@ skipping 67 matching lines @@
       delay_);
 }
 
 SerialConnection::TimeoutTask::~TimeoutTask() {}
 
 void SerialConnection::TimeoutTask::Run() const {
   closure_.Run();
 }
 
 }  // namespace extensions