Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5144)

Unified Diff: chrome/browser/extensions/api/serial/serial_port_enumerator_unittest.cc

Issue 158063002: Use udev for serial device enumeration on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: -___- Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_port_enumerator_unittest.cc
diff --git a/chrome/browser/extensions/api/serial/serial_port_enumerator_unittest.cc b/chrome/browser/extensions/api/serial/serial_port_enumerator_unittest.cc
deleted file mode 100644
index 8921f9a70d45505ea98abdd2397ea33800c10b56..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/serial/serial_port_enumerator_unittest.cc
+++ /dev/null
@@ -1,69 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/strings/string_util.h"
-#include "chrome/browser/extensions/api/serial/serial_port_enumerator.h"
-#include "chrome/common/extensions/extension_test_util.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-TEST(SerialPortEnumeratorTest, ValidPortNamePatterns) {
-#if defined(OS_WIN)
- // TODO(miket): implement
-#else
- const extensions::SerialPortEnumerator::StringSet port_patterns(
- extensions::SerialPortEnumerator::GenerateValidPatterns());
-
- const char *kValidNames[] = {
- "/dev/867serial5309",
- "/dev/tty.usbmodem999999",
- "/dev/ttyACM0",
- "/dev/xxxxxmodemxxxxxxxxxx",
- "/dev/tty.SLAB_something",
- "/dev/cu.SLAB_anything",
- };
-
- for (size_t i = 0; i < arraysize(kValidNames); ++i) {
- std::set<std::string>::const_iterator j = port_patterns.begin();
- for (; j != port_patterns.end(); ++j) {
- if (MatchPattern(kValidNames[i], *j)) {
- break;
- }
- }
- EXPECT_TRUE(j != port_patterns.end()) << kValidNames[i] <<
- " should have matched at least one pattern";
- }
-#endif
-}
-
-TEST(SerialPortEnumeratorTest, InvalidPortNamePatterns) {
-#if defined(OS_WIN)
-#else
- const extensions::SerialPortEnumerator::StringSet port_patterns(
- extensions::SerialPortEnumerator::GenerateValidPatterns());
-
- const char *kInvalidNames[] = {
- "",
- ".",
- "..",
- "//COM0",
- "/dev/../home/you/your_secrets",
- "/dev/cdrom",
- "/dev/laserbeam",
- "/home/you/your_secrets",
- "/proc/cpuinfo",
- "COM0",
- "\\\\COM0",
- "modem",
- "serial",
- "tty",
- };
-
- for (size_t i = 0; i < arraysize(kInvalidNames); ++i) {
- std::set<std::string>::const_iterator j = port_patterns.begin();
- for (; j != port_patterns.end(); ++j)
- EXPECT_FALSE(MatchPattern(kInvalidNames[i], *j)) <<
- kInvalidNames[i] << " should not have matched " << *j;
- }
-#endif
-}

Powered by Google App Engine
This is Rietveld 408576698