Issue 1580503004: CSS Invalidation: Avoid virtual functions in InvalidationSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1580503004: CSS Invalidation: Avoid virtual functions in InvalidationSet (Closed)

Created:
4 years, 11 months ago by Eric Willigers

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

CSS Invalidation: Avoid virtual functions in InvalidationSet Virtual functions were unnecessarily added to InvalidationSet by https://codereview.chromium.org/1317533002 These have a memory cost when there are many style rules and/or many elements scheduled for style invalidation. BUG=556531 Review URL: https://codereview.chromium.org/1480973002 Cr-Commit-Position: refs/heads/master@{#363166} (cherry picked from commit 580ea704c5158d858ad9ba20eb3783f8883d8689) Committed: https://chromium.googlesource.com/chromium/src/+/e61ee7ecab43e75ac3fe2903632ab5d2c3b4debe

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
	M	third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h	View		5 chunks	+16 lines, -10 lines	0 comments	Download
	M	third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp	View		4 chunks	+15 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Eric Willigers

4 years, 11 months ago (2016-01-11 23:52:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e61ee7ecab43e75ac3fe2903632ab5d2c3b4debe.