CSS Invalidation: Avoid virtual functions in InvalidationSet

third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 
 #define TRACE_STYLE_INVALIDATOR_INVALIDATION_SELECTORPART_IF_ENABLED(element, reason, invalidationSet, singleSelectorPart) \
     if (UNLIKELY(*s_tracingEnabled)) \
         TRACE_STYLE_INVALIDATOR_INVALIDATION_SELECTORPART(element, reason, invalidationSet, singleSelectorPart);
 
 void InvalidationSet::cacheTracingFlag()
 {
     s_tracingEnabled = TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"));
 }
 
-InvalidationSet::InvalidationSet()
-    : m_allDescendantsMightBeInvalid(false)
+InvalidationSet::InvalidationSet(InvalidationType type)
+    : m_type(type)
+    , m_allDescendantsMightBeInvalid(false)
     , m_invalidatesSelf(false)
     , m_customPseudoInvalid(false)
     , m_treeBoundaryCrossing(false)
     , m_insertionPointCrossing(false)
 {
 }
 
 bool InvalidationSet::invalidatesElement(Element& element) const
 {
     if (m_allDescendantsMightBeInvalid)
@@ skipping 26 matching lines @@
                 return true;
             }
         }
     }
 
     return false;
 }
 
 void InvalidationSet::combine(const InvalidationSet& other)
 {
+    ASSERT(m_type == other.m_type);
+
     // No longer bother combining data structures, since the whole subtree is deemed invalid.
     if (wholeSubtreeInvalid())
         return;
 
     if (other.wholeSubtreeInvalid()) {
         setWholeSubtreeInvalid();
         return;
     }
 
     if (other.invalidatesSelf())
@@ skipping 22 matching lines @@
         for (const auto& tagName : *other.m_tagNames)
             addTagName(tagName);
     }
 
     if (other.m_attributes) {
         for (const auto& attribute : *other.m_attributes)
             addAttribute(attribute);
     }
 }
 
+void InvalidationSet::destroy()
+{
+    if (isDescendantInvalidationSet())
+        delete toDescendantInvalidationSet(this);
+    else
+        delete toSiblingInvalidationSet(this);
+}
+
 HashSet<AtomicString>& InvalidationSet::ensureClassSet()
 {
     if (!m_classes)
         m_classes = adoptPtr(new HashSet<AtomicString>);
     return *m_classes;
 }
 
 HashSet<AtomicString>& InvalidationSet::ensureIdSet()
 {
     if (!m_ids)
@@ skipping 109 matching lines @@
 {
     RefPtr<TracedValue> value = TracedValue::create();
     value->beginArray("InvalidationSet");
     toTracedValue(value.get());
     value->endArray();
     fprintf(stderr, "%s\n", value->asTraceFormat().ascii().data());
 }
 #endif // NDEBUG
 
 SiblingInvalidationSet::SiblingInvalidationSet()
-    : m_maxDirectAdjacentSelectors(1)
+    : InvalidationSet(InvalidateSiblings)
+    , m_maxDirectAdjacentSelectors(1)
     , m_descendantInvalidationSet(DescendantInvalidationSet::create())
 {
 }
 
 void SiblingInvalidationSet::combine(const SiblingInvalidationSet& other)
 {
     m_maxDirectAdjacentSelectors = std::max(m_maxDirectAdjacentSelectors, other.m_maxDirectAdjacentSelectors);
     m_descendantInvalidationSet->combine(other.descendants());
 
     InvalidationSet::combine(other);
 }
 
 } // namespace blink