CSS Invalidation: Avoid virtual functions in InvalidationSet

CSS Invalidation: Avoid virtual functions in InvalidationSet

Virtual functions were unnecessarily added to InvalidationSet by
https://codereview.chromium.org/1317533002

These have a memory cost when there are many style rules and/or
many elements scheduled for style invalidation.

BUG=556531
Committed: https://crrev.com/580ea704c5158d858ad9ba20eb3783f8883d8689
Cr-Commit-Position: refs/heads/master@{#363166}

[Eric Willigers, 2015-11-27 00:43:51]

ericwilligers@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2015-11-27 00:45:57]

ok lgtm

[esprehn, 2015-12-03 08:40:01]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-12-03 08:40:01]

lgtm

[esprehn, 2015-12-03 08:40:05]

Can we land this?

[Eric Willigers, 2015-12-04 05:47:01]

This patch was receiving Windows debug compile failures:
RefCounted<InvalidationSet>::deref() cannot access protected ~InvalidationSet

I'm now avoiding the failure by not declaring the destructor protected.
StylePropertySet uses a similar deref approach to this patch, and it doesn't
have a protected destructor.

[Eric Willigers, 2015-12-04 05:47:15]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2015-12-04 05:47:15]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1480973002/#ps40001
(title: "no protected destructor")

[commit-bot: I haz the power, 2015-12-04 05:47:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480973002/40001

[commit-bot: I haz the power, 2015-12-04 08:06:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-04 08:07:25]

Description was changed from

==========
CSS Invalidation: Avoid virtual functions in InvalidationSet

Virtual functions were unnecessarily added to InvalidationSet by
https://codereview.chromium.org/1317533002

These have a memory cost when there are many style rules and/or
many elements scheduled for style invalidation.


BUG=556531
==========

to

==========
CSS Invalidation: Avoid virtual functions in InvalidationSet

Virtual functions were unnecessarily added to InvalidationSet by
https://codereview.chromium.org/1317533002

These have a memory cost when there are many style rules and/or
many elements scheduled for style invalidation.

BUG=556531

Committed: https://crrev.com/580ea704c5158d858ad9ba20eb3783f8883d8689
Cr-Commit-Position: refs/heads/master@{#363166}
==========

[commit-bot: I haz the power, 2015-12-04 08:07:27]

Patchset 3 (id:??) landed as
https://crrev.com/580ea704c5158d858ad9ba20eb3783f8883d8689
Cr-Commit-Position: refs/heads/master@{#363166}