Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed)

Created:
4 years, 11 months ago by hyunjunekim2
Modified:
4 years, 10 months ago
Reviewers:
pdr., fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect handling of small non-percentage value for `st- artOffset`. Just only recognize with `percentage` when return value on `startOffset` that is normalize value between 0 and 1. Because occur to the problem on `SVGTextLayoutEngine::begin- TextPathLayout`. So check whether percentage or not, If no percentage, don't recognize to normalize value. BUG=576702 Committed: https://crrev.com/384c36b5312ea0dd7557ab5fbfe7ed79b02f1303 Cr-Commit-Position: refs/heads/master@{#372225}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 5

Patch Set 8 : Modify a test. #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : #

Total comments: 1

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/text/textpath-startoffset-expected.html View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
hyunjunekim2
fs, pdr Could you check this patch? Thank you. ;)
4 years, 11 months ago (2016-01-18 10:00:21 UTC) #5
fs
https://codereview.chromium.org/1580293008/diff/40001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html File third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html (right): https://codereview.chromium.org/1580293008/diff/40001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html#newcode1 third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html:1: <!DOCTYPE html> Please don't add a pixeltest for this ...
4 years, 11 months ago (2016-01-18 12:57:49 UTC) #6
hyunjunekim2
fs, Could you check PS7?
4 years, 10 months ago (2016-01-28 13:12:50 UTC) #7
fs
https://codereview.chromium.org/1580293008/diff/120001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html File third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html (right): https://codereview.chromium.org/1580293008/diff/120001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html#newcode4 third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html:4: <text fill="red" font-family="Arial"><textPath xlink:href="#path">Test</textPath></text> Since this is a ref-test ...
4 years, 10 months ago (2016-01-28 14:00:20 UTC) #8
hyunjunekim2
On 2016/01/28 14:00:20, fs wrote: > https://codereview.chromium.org/1580293008/diff/120001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html > File third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html (right): > > https://codereview.chromium.org/1580293008/diff/120001/third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html#newcode4 > ...
4 years, 10 months ago (2016-01-28 15:05:02 UTC) #9
fs
https://codereview.chromium.org/1580293008/diff/160001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp (right): https://codereview.chromium.org/1580293008/diff/160001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp#newcode68 third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp:68: if (isPercentageForStartOffset(this)) { This is unnecessarily complicated, just do: ...
4 years, 10 months ago (2016-01-28 15:20:34 UTC) #10
hyunjunekim2
On 2016/01/28 15:20:34, fs wrote: > https://codereview.chromium.org/1580293008/diff/160001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp > File third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp (right): > > https://codereview.chromium.org/1580293008/diff/160001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp#newcode68 > ...
4 years, 10 months ago (2016-01-28 15:47:31 UTC) #11
fs
LGTM w/ nit https://codereview.chromium.org/1580293008/diff/180001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp File third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp (right): https://codereview.chromium.org/1580293008/diff/180001/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp#newcode66 third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp:66: } Nit: Remove { }
4 years, 10 months ago (2016-01-28 15:50:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580293008/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580293008/200001
4 years, 10 months ago (2016-01-28 23:03:12 UTC) #15
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 10 months ago (2016-01-29 00:42:54 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:43:42 UTC) #19
Message was sent while issue was closed. 
Patchset 11 (id:??) landed as
https://crrev.com/384c36b5312ea0dd7557ab5fbfe7ed79b02f1303
Cr-Commit-Position: refs/heads/master@{#372225}

Powered by Google App Engine
This is Rietveld 408576698