third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index b35a859b92e53ede32da378a9df743f1f80c6e92..f746385496ae0a2289962a75afd1548e35181379 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -177,10 +177,8 @@ void SVGTextLayoutEngine::beginTextPathLayout(SVGInlineFlowBox* flowBox)

if (path.isEmpty())

return;

m_textPathCalculator = new Path::PositionCalculator(path);

- m_textPathStartOffset = textPath->startOffset();

m_textPathLength = path.length();

- if (m_textPathStartOffset > 0 && m_textPathStartOffset <= 1)

- m_textPathStartOffset *= m_textPathLength;

+ m_textPathStartOffset = textPath->calculateStartOffset(m_textPathLength);

SVGTextPathChunkBuilder textPathChunkLayoutBuilder;

textPathChunkLayoutBuilder.processTextChunks(lineLayout.m_lineLayoutBoxes);

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp ('k') | no next file » | no next file with comments »