Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 12 matching lines...) Expand all
23 23
24 #include "core/layout/svg/LayoutSVGInline.h" 24 #include "core/layout/svg/LayoutSVGInline.h"
25 25
26 namespace blink { 26 namespace blink {
27 27
28 class LayoutSVGTextPath final : public LayoutSVGInline { 28 class LayoutSVGTextPath final : public LayoutSVGInline {
29 public: 29 public:
30 explicit LayoutSVGTextPath(Element*); 30 explicit LayoutSVGTextPath(Element*);
31 31
32 Path layoutPath() const; 32 Path layoutPath() const;
33 float startOffset() const; 33 float calculateStartOffset(float length) const;
fs 2016/01/28 15:20:34 Nit: s/length/pathLength/
34 34
35 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override; 35 bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
36 36
37 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGTextPath || LayoutSVGInline::isOfType(type); } 37 bool isOfType(LayoutObjectType type) const override { return type == LayoutO bjectSVGTextPath || LayoutSVGInline::isOfType(type); }
38 38
39 const char* name() const override { return "LayoutSVGTextPath"; } 39 const char* name() const override { return "LayoutSVGTextPath"; }
40 40
41 private: 41 private:
42 Path m_layoutPath; 42 Path m_layoutPath;
43 }; 43 };
44 44
45 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGTextPath, isSVGTextPath()); 45 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGTextPath, isSVGTextPath());
46 46
47 } // namespace blink 47 } // namespace blink
48 48
49 #endif // LayoutSVGTextPath_h 49 #endif // LayoutSVGTextPath_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698