Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1580193004: [cq] Keep presubmit trybots and cq automatically in sync. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cq] Keep presubmit trybots and cq automatically in sync. Code copied 1:1 from chromium. BUG=chromium:565952 LOG=n NOTRY=true Committed: https://crrev.com/039dce1e355be6422c672badef5f3895f3b16ead Cr-Commit-Position: refs/heads/master@{#33264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M PRESUBMIT.py View 1 chunk +24 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-13 14:11:38 UTC) #3
tandrii(chromium)
LGTM though https://codereview.chromium.org/1579423004/ :)
4 years, 11 months ago (2016-01-13 14:51:33 UTC) #5
Michael Achenbach
OK - I'll commit until your CL lands...
4 years, 11 months ago (2016-01-13 14:54:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580193004/1
4 years, 11 months ago (2016-01-13 14:54:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 15:06:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/039dce1e355be6422c672badef5f3895f3b16ead Cr-Commit-Position: refs/heads/master@{#33264}
4 years, 11 months ago (2016-01-13 15:07:38 UTC) #12
Michael Achenbach
4 years, 11 months ago (2016-01-14 08:00:39 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1579223004/ by machenbach@chromium.org.

The reason for reverting is: Doesn't work with triggered bots. Waiting for this
fix: https://codereview.chromium.org/1587893003/.

Powered by Google App Engine
This is Rietveld 408576698