Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: PRESUBMIT.py

Issue 1580193004: [cq] Keep presubmit trybots and cq automatically in sync. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 results.extend(input_api.canned_checks.CheckChangeHasDescription( 271 results.extend(input_api.canned_checks.CheckChangeHasDescription(
272 input_api, output_api)) 272 input_api, output_api))
273 if not _SkipTreeCheck(input_api, output_api): 273 if not _SkipTreeCheck(input_api, output_api):
274 results.extend(input_api.canned_checks.CheckTreeIsOpen( 274 results.extend(input_api.canned_checks.CheckTreeIsOpen(
275 input_api, output_api, 275 input_api, output_api,
276 json_url='http://v8-status.appspot.com/current?format=json')) 276 json_url='http://v8-status.appspot.com/current?format=json'))
277 return results 277 return results
278 278
279 279
280 def GetPreferredTryMasters(project, change): 280 def GetPreferredTryMasters(project, change):
281 return { 281 import json
282 'tryserver.v8': { 282 import os.path
283 'v8_linux_rel_ng': set(['defaulttests']), 283 import platform
284 'v8_linux_dbg_ng': set(['defaulttests']), 284 import subprocess
285 'v8_linux_nodcheck_rel': set(['defaulttests']), 285
286 'v8_linux_gcc_compile_rel': set(['defaulttests']), 286 cq_config_path = os.path.join(
287 'v8_linux64_rel_ng': set(['defaulttests']), 287 change.RepositoryRoot(), 'infra', 'config', 'cq.cfg')
288 'v8_linux64_asan_rel': set(['defaulttests']), 288 # commit_queue.py below is a script in depot_tools directory, which has a
289 'v8_linux64_avx2_rel': set(['defaulttests']), 289 # 'builders' command to retrieve a list of CQ builders from the CQ config.
290 'v8_win_rel_ng': set(['defaulttests']), 290 is_win = platform.system() == 'Windows'
291 'v8_win_compile_dbg': set(['defaulttests']), 291 masters = json.loads(subprocess.check_output(
292 'v8_win_nosnap_shared_compile_rel': set(['defaulttests']), 292 ['commit_queue', 'builders', cq_config_path], shell=is_win))
293 'v8_win64_rel_ng': set(['defaulttests']), 293
294 'v8_mac_rel': set(['defaulttests']), 294 try_config = {}
295 'v8_linux_arm_rel': set(['defaulttests']), 295 for master in masters:
296 'v8_linux_arm64_rel': set(['defaulttests']), 296 try_config.setdefault(master, {})
297 'v8_linux_mipsel_compile_rel': set(['defaulttests']), 297 for builder in masters[master]:
298 'v8_linux_mips64el_compile_rel': set(['defaulttests']), 298 # Do not trigger presubmit builders, since they're likely to fail
299 'v8_android_arm_compile_rel': set(['defaulttests']), 299 # (e.g. OWNERS checks before finished code review), and we're
300 'v8_linux_chromium_gn_rel': set(['defaulttests']), 300 # running local presubmit anyway.
301 }, 301 if 'presubmit' not in builder:
302 } 302 try_config[master][builder] = ['defaulttests']
303
304 return try_config
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698