Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: PRESUBMIT.py

Issue 1580193004: [cq] Keep presubmit trybots and cq automatically in sync. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index e6b528e75795668a2a9c1589a6a410dfce26cf2e..91b67f5e01db3c63a65f578bf57bc6f7c0afc4bd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -278,25 +278,27 @@ def CheckChangeOnCommit(input_api, output_api):
def GetPreferredTryMasters(project, change):
- return {
- 'tryserver.v8': {
- 'v8_linux_rel_ng': set(['defaulttests']),
- 'v8_linux_dbg_ng': set(['defaulttests']),
- 'v8_linux_nodcheck_rel': set(['defaulttests']),
- 'v8_linux_gcc_compile_rel': set(['defaulttests']),
- 'v8_linux64_rel_ng': set(['defaulttests']),
- 'v8_linux64_asan_rel': set(['defaulttests']),
- 'v8_linux64_avx2_rel': set(['defaulttests']),
- 'v8_win_rel_ng': set(['defaulttests']),
- 'v8_win_compile_dbg': set(['defaulttests']),
- 'v8_win_nosnap_shared_compile_rel': set(['defaulttests']),
- 'v8_win64_rel_ng': set(['defaulttests']),
- 'v8_mac_rel': set(['defaulttests']),
- 'v8_linux_arm_rel': set(['defaulttests']),
- 'v8_linux_arm64_rel': set(['defaulttests']),
- 'v8_linux_mipsel_compile_rel': set(['defaulttests']),
- 'v8_linux_mips64el_compile_rel': set(['defaulttests']),
- 'v8_android_arm_compile_rel': set(['defaulttests']),
- 'v8_linux_chromium_gn_rel': set(['defaulttests']),
- },
- }
+ import json
+ import os.path
+ import platform
+ import subprocess
+
+ cq_config_path = os.path.join(
+ change.RepositoryRoot(), 'infra', 'config', 'cq.cfg')
+ # commit_queue.py below is a script in depot_tools directory, which has a
+ # 'builders' command to retrieve a list of CQ builders from the CQ config.
+ is_win = platform.system() == 'Windows'
+ masters = json.loads(subprocess.check_output(
+ ['commit_queue', 'builders', cq_config_path], shell=is_win))
+
+ try_config = {}
+ for master in masters:
+ try_config.setdefault(master, {})
+ for builder in masters[master]:
+ # Do not trigger presubmit builders, since they're likely to fail
+ # (e.g. OWNERS checks before finished code review), and we're
+ # running local presubmit anyway.
+ if 'presubmit' not in builder:
+ try_config[master][builder] = ['defaulttests']
+
+ return try_config
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698