Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: content/test/test_render_view_host_factory.h

Issue 15799009: Store the RenderProcessHostFactory in a global variable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_instance_impl_unittest.cc ('k') | content/test/test_render_view_host_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_view_host_factory.h
diff --git a/content/test/test_render_view_host_factory.h b/content/test/test_render_view_host_factory.h
index 6b9b45e9e502281df7ba3e5b08e8940d918171c4..d194b2cb92b0bc6ddf758dfbe0546a7b7e483819 100644
--- a/content/test/test_render_view_host_factory.h
+++ b/content/test/test_render_view_host_factory.h
@@ -37,15 +37,6 @@ class TestRenderViewHostFactory : public RenderViewHostFactory {
SessionStorageNamespace* session_storage) OVERRIDE;
private:
- // This is a bit of a hack. With the current design of the site instances /
- // browsing instances, it's difficult to pass a RenderProcessHostFactory
- // around properly.
- //
- // Instead, we set it right before we create a new RenderViewHost, which
- // happens before the RenderProcessHost is created. This way, the instance
- // has the correct factory and creates our special RenderProcessHosts.
- RenderProcessHostFactory* render_process_host_factory_;
-
DISALLOW_COPY_AND_ASSIGN(TestRenderViewHostFactory);
};
« no previous file with comments | « content/browser/site_instance_impl_unittest.cc ('k') | content/test/test_render_view_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698