Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1579693004: Merget to XFA: Use std::map in CPDF_IndirectObjects (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merget to XFA: Use std::map in CPDF_IndirectObjects Review URL: https://codereview.chromium.org/1576113003 . (cherry picked from commit fce548047a44c7015996874452f3e778bf64cad6) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/067e2b4fe59b70291ee19705ba45575ec39feb9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -179 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 8 chunks +28 lines, -36 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 5 chunks +12 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 4 chunks +11 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 8 chunks +63 lines, -83 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 7 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR
4 years, 11 months ago (2016-01-12 16:46:39 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 067e2b4fe59b70291ee19705ba45575ec39feb9d (presubmit successful).
4 years, 11 months ago (2016-01-12 16:54:53 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-12 18:44:11 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698