Use std::map in CPDF_IndirectObjects

Use std::map in CPDF_IndirectObjects

Rename to CPDF_IndirectObjectHolder

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/fce548047a44c7015996874452f3e778bf64cad6

[Tom Sepez, 2016-01-11 20:48:04]

Description was changed from

==========
Remove CFX_MapPtrToPtr
==========

to

==========
Rename to CPDF_IndirectObjectHolder
==========

[Tom Sepez, 2016-01-11 20:48:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-01-11 20:53:33]

Lei, diff PS#2 against PS#1 for manual changes.

[Lei Zhang, 2016-01-11 21:34:51]

Description was changed from

==========
Rename to CPDF_IndirectObjectHolder
==========

to

==========
Use std::map in CPDF_IndirectObjects

Rename to CPDF_IndirectObjectHolder
==========

[Lei Zhang, 2016-01-12 01:21:51]

https://codereview.chromium.org/1576113003/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1576113003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_objects.h:596: const_iterator cbegin() const { return
m_IndirectObjs.cbegin(); }
Can't these just be begin() and end()? The compiler should pick the const
version. As written, std::cbegin/std::cend are still in the "C++11 Standard
Library Features To Be Discussed" section, so I'm guessing that applies to
std::map::cbegin/cend as well?

[Lei Zhang, 2016-01-12 01:26:20]

otherwise lgtm

[Tom Sepez, 2016-01-12 16:41:17]

https://codereview.chromium.org/1576113003/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1576113003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_objects.h:596: const_iterator cbegin() const { return
m_IndirectObjs.cbegin(); }
On 2016/01/12 01:21:51, Lei Zhang wrote:
> Can't these just be begin() and end()? The compiler should pick the const
> version. As written, std::cbegin/std::cend are still in the "C++11 Standard
> Library Features To Be Discussed" section, so I'm guessing that applies to
> std::map::cbegin/cend as well?

Done.

[Tom Sepez, 2016-01-12 16:41:53]

Description was changed from

==========
Use std::map in CPDF_IndirectObjects

Rename to CPDF_IndirectObjectHolder
==========

to

==========
Use std::map in CPDF_IndirectObjects

Rename to CPDF_IndirectObjectHolder

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/fce548047a44c7015996874452f3e778bf64...
==========

[Tom Sepez, 2016-01-12 16:41:54]

Committed patchset #3 (id:40001) manually as
fce548047a44c7015996874452f3e778bf64cad6 (presubmit successful).