Merget to XFA: Use std::map in CPDF_IndirectObjects

core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfapi/fpdf_parser.h"
 
 #include "core/include/fpdfapi/fpdf_module.h"
 
 CPDF_Document::CPDF_Document(CPDF_Parser* pParser)
-    : CPDF_IndirectObjects(pParser) {
+    : CPDF_IndirectObjectHolder(pParser) {
   ASSERT(pParser);
   m_pRootDict = NULL;
   m_pInfoDict = NULL;
   m_bLinearized = FALSE;
   m_dwFirstPageNo = 0;
   m_dwFirstPageObjNum = 0;
   m_pDocPage = CPDF_ModuleMgr::Get()->GetPageModule()->CreateDocData(this);
   m_pDocRender = CPDF_ModuleMgr::Get()->GetRenderModule()->CreateDocData(this);
 }
 CPDF_DocPageData* CPDF_Document::GetValidatePageData() {
@@ skipping 302 matching lines @@
 FX_DWORD CPDF_Document::GetUserPermissions(FX_BOOL bCheckRevision) const {
   if (!m_pParser) {
     return (FX_DWORD)-1;
   }
   return m_pParser->GetPermissions(bCheckRevision);
 }
 FX_BOOL CPDF_Document::IsOwner() const {
   return !m_pParser || m_pParser->IsOwner();
 }
 FX_BOOL CPDF_Document::IsFormStream(FX_DWORD objnum, FX_BOOL& bForm) const {
-  {
-    CPDF_Object* pObj;
-    if (m_IndirectObjs.Lookup((void*)(uintptr_t)objnum, (void*&)pObj)) {
-      CPDF_Stream* pStream = pObj->AsStream();
-      bForm = pStream && pStream->GetDict()->GetString("Subtype") == "Form";
-      return TRUE;
-    }
+  auto it = m_IndirectObjs.find(objnum);
+  if (it != m_IndirectObjs.end()) {
+    CPDF_Stream* pStream = it->second->AsStream();
+    bForm = pStream && pStream->GetDict()->GetString("Subtype") == "Form";
+    return TRUE;
   }
   if (!m_pParser) {
     bForm = FALSE;
     return TRUE;
   }
   return m_pParser->IsFormStream(objnum, bForm);
 }
 void CPDF_Document::ClearPageData() {
   if (m_pDocPage) {
     CPDF_ModuleMgr::Get()->GetPageModule()->ClearDoc(this);
   }
 }
 void CPDF_Document::ClearRenderData() {
   if (m_pDocRender) {
     CPDF_ModuleMgr::Get()->GetRenderModule()->ClearDocData(m_pDocRender);
   }
 }