Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1579633003: cc: Avoid crash on Android in GLRenderer (Closed)

Created:
4 years, 11 months ago by no sievers
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

cc: Avoid crash on Android in GLRenderer We don't really handle GetVideoStreamTextureProgram() returning null gracefully, so avoid the crash. However, any broken implementation that was crashing here will still not render embedded videos and cause GL errors (since successfull shader compilation and use of GLenums are also gated on the extension). BUG=350443 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1515723002 Cr-Commit-Position: refs/heads/master@{#364263} (cherry picked from commit 46c880331aaad20da0d966ca2240ff820bb41e28) Committed: https://chromium.googlesource.com/chromium/src/+/ce67989b20608442e48144cd32e4a85d6e01e841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
no sievers
4 years, 11 months ago (2016-01-11 20:56:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce67989b20608442e48144cd32e4a85d6e01e841.

Powered by Google App Engine
This is Rietveld 408576698