cc: Avoid crash on Android in GLRenderer

cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/46c880331aaad20da0d966ca2240ff820bb41e28
Cr-Commit-Position: refs/heads/master@{#364263}

[no sievers, 2015-12-09 22:17:10]

Description was changed from

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
==========

to

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[no sievers, 2015-12-09 22:17:23]

Description was changed from

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[no sievers, 2015-12-09 22:17:23]

sievers@chromium.org changed reviewers:
+ danakj@chromium.org

[no sievers, 2015-12-09 22:18:06]

I can remove the cap bool separately now that it looks like that bit is only
used for a DCHECK()(but this is more minimal for merging).

[no sievers, 2015-12-09 22:18:49]

On 2015/12/09 22:18:06, sievers wrote:
> I can remove the cap bool separately now that it looks like that bit is only
> used for a DCHECK()(but this is more minimal for merging).

Oh we use it in gl_renderer_unittest.cc.

[danakj, 2015-12-09 22:19:09]

On 2015/12/09 22:18:06, sievers wrote:
> I can remove the cap bool separately now that it looks like that bit is only
> used for a DCHECK()(but this is more minimal for merging).

Yes plz. LGTM and LGTM++ for removing the bool.

[no sievers, 2015-12-09 22:19:23]

The CQ bit was checked by sievers@chromium.org

[danakj, 2015-12-09 22:19:53]

On 2015/12/09 22:18:49, sievers wrote:
> On 2015/12/09 22:18:06, sievers wrote:
> > I can remove the cap bool separately now that it looks like that bit is only
> > used for a DCHECK()(but this is more minimal for merging).
> 
> Oh we use it in gl_renderer_unittest.cc.

I think we can just remove that branch? It looks like it's testing the null.

[commit-bot: I haz the power, 2015-12-09 22:23:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515723002/1

[commit-bot: I haz the power, 2015-12-09 23:40:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 23:40:22]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[no sievers, 2015-12-09 23:58:42]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2015-12-09 23:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1515723002/#ps20001
(title: "test")

[commit-bot: I haz the power, 2015-12-09 23:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515723002/20001

[danakj, 2015-12-10 00:00:04]

https://codereview.chromium.org/1515723002/diff/20001/cc/output/gl_renderer_u...
File cc/output/gl_renderer_unittest.cc (right):

https://codereview.chromium.org/1515723002/diff/20001/cc/output/gl_renderer_u...
cc/output/gl_renderer_unittest.cc:135: if
(renderer()->Capabilities().using_egl_image)
can you remove this at the same time?

[danakj, 2015-12-10 00:00:18]

The CQ bit was unchecked by danakj@chromium.org

[no sievers, 2015-12-10 00:05:51]

https://codereview.chromium.org/1515723002/diff/20001/cc/output/gl_renderer_u...
File cc/output/gl_renderer_unittest.cc (right):

https://codereview.chromium.org/1515723002/diff/20001/cc/output/gl_renderer_u...
cc/output/gl_renderer_unittest.cc:135: if
(renderer()->Capabilities().using_egl_image)
On 2015/12/10 00:00:04, danakj (behind on reviews) wrote:
> can you remove this at the same time?

makes sense. done.

[danakj, 2015-12-10 00:13:36]

https://codereview.chromium.org/1515723002/diff/40001/cc/output/gl_renderer_u...
File cc/output/gl_renderer_unittest.cc (left):

https://codereview.chromium.org/1515723002/diff/40001/cc/output/gl_renderer_u...
cc/output/gl_renderer_unittest.cc:136:
EXPECT_PROGRAM_VALID(renderer()->GetVideoStreamTextureProgram(precision));
I think you wanna keep this tho? :) sorry hehe, we wanna make sure the program
can compile always?

[no sievers, 2015-12-10 00:16:27]

https://codereview.chromium.org/1515723002/diff/40001/cc/output/gl_renderer_u...
File cc/output/gl_renderer_unittest.cc (left):

https://codereview.chromium.org/1515723002/diff/40001/cc/output/gl_renderer_u...
cc/output/gl_renderer_unittest.cc:136:
EXPECT_PROGRAM_VALID(renderer()->GetVideoStreamTextureProgram(precision));
On 2015/12/10 00:13:36, danakj (behind on reviews) wrote:
> I think you wanna keep this tho? :) sorry hehe, we wanna make sure the program
> can compile always?

Done.

[no sievers, 2015-12-10 00:19:43]

Patchset #3 (id:40001) has been deleted

[no sievers, 2015-12-10 00:19:50]

Patchset #3 (id:60001) has been deleted

[no sievers, 2015-12-10 00:22:17]

and comment added.

[danakj, 2015-12-10 00:23:50]

Thanks LGTM

[no sievers, 2015-12-10 00:24:35]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2015-12-10 00:25:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1515723002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1515723002/80001

[commit-bot: I haz the power, 2015-12-10 02:20:31]

Description was changed from

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-10 02:20:31]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-12-10 02:21:47]

Description was changed from

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Avoid crash on Android in GLRenderer

We don't really handle GetVideoStreamTextureProgram() returning
null gracefully, so avoid the crash.
However, any broken implementation that was crashing here will
still not render embedded videos and cause GL errors
(since successfull shader compilation and use of GLenums
are also gated on the extension).

BUG=350443
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/46c880331aaad20da0d966ca2240ff820bb41e28
Cr-Commit-Position: refs/heads/master@{#364263}
==========

[commit-bot: I haz the power, 2015-12-10 02:21:49]

Patchset 3 (id:??) landed as
https://crrev.com/46c880331aaad20da0d966ca2240ff820bb41e28
Cr-Commit-Position: refs/heads/master@{#364263}