[DevTools] Blackbox sources with inline source maps

[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews

Committed: https://crrev.com/8f131d2e7ed396d2f68d6762f0eb414f1ed8fae4
Cr-Commit-Position: refs/heads/master@{#370182}

[kozy, 2016-01-12 21:29:03]

ptal!

[kozy, 2016-01-12 22:02:40]

Description was changed from

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org
==========

[kozy, 2016-01-12 22:02:40]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2016-01-12 22:04:26]

Dmitry, please take a look!

[dgozman, 2016-01-13 01:28:50]

no Nullable please!

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html
(right):

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html:11:
foo();
Let's make it foo(bar), where bar is defined in this file.

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:129: KURL
sourceMapURL(ParsedURLString, url);
KURL kurl(KURL(), url);

[kozy, 2016-01-13 20:47:57]

All done!
All nullable references are destroyed!

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html
(right):

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html:11:
foo();
On 2016/01/13 01:28:49, dgozman wrote:
> Let's make it foo(bar), where bar is defined in this file.

Done.

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:129: KURL
sourceMapURL(ParsedURLString, url);
On 2016/01/13 01:28:49, dgozman wrote:
> KURL kurl(KURL(), url);

Done.

[dgozman, 2016-01-14 00:03:06]

lgtm

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map-compiled.js
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map-compiled.js:4:
var res = boo();
I'd also add a statement before calling into boo() to check that it's skipped.

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map.js
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map.js:3:
return 239;
This does not match compiled version.

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:127: static
OwnPtr<SourceMap> parseSourceMapFromDataUrl(const String& url)
PassOwnPtr

[kozy, 2016-01-14 00:38:32]

All done.

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map-compiled.js
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map-compiled.js:4:
var res = boo();
On 2016/01/14 00:03:06, dgozman wrote:
> I'd also add a statement before calling into boo() to check that it's skipped.

Done.

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map.js
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/framework-with-source-map.js:3:
return 239;
On 2016/01/14 00:03:06, dgozman wrote:
> This does not match compiled version.

Done.

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:127: static
OwnPtr<SourceMap> parseSourceMapFromDataUrl(const String& url)
On 2016/01/14 00:03:06, dgozman wrote:
> PassOwnPtr

Done.

[kozy, 2016-01-15 01:33:28]

Description was changed from

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org
==========

to

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews
==========

[kozy, 2016-01-15 01:33:29]

kozyatinskiy@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[kozy, 2016-01-15 01:37:58]

I need oilpan review.
please take a look!

[haraken, 2016-01-15 02:42:07]

Where is the implementation of SourceMap? I cannot find it on ToT.

[kozy, 2016-01-15 04:31:52]

On 2016/01/15 02:42:07, haraken wrote:
> Where is the implementation of SourceMap? I cannot find it on ToT.

It's in separated CL: https://codereview.chromium.org/1587933004#ps1

[pfeldman, 2016-01-15 22:55:27]

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html
(right):

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html:1:
<html>
This should be a protocol test.

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:538: String
scriptURL = it->value.sourceURL();
I don't quite like the behavior - depending on whether source map can be loaded,
we'll behave differently. It might be nice to check both URLs.

[kozy, 2016-01-16 00:22:04]

Patchset #6 (id:100001) has been deleted

[kozy, 2016-01-16 00:23:16]

All done! Still need review from oilpan team.

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html
(right):

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-step-in-with-source-map.html:1:
<html>
On 2016/01/15 22:55:27, pfeldman wrote:
> This should be a protocol test.

Done.

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1579283002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:538: String
scriptURL = it->value.sourceURL();
On 2016/01/15 22:55:27, pfeldman wrote:
> I don't quite like the behavior - depending on whether source map can be
loaded,
> we'll behave differently. It might be nice to check both URLs.

Done.

[kozy, 2016-01-16 00:56:12]

Patchset #6 (id:120001) has been deleted

[kozy, 2016-01-16 01:03:08]

Patchset #6 (id:140001) has been deleted

[kozy, 2016-01-16 19:43:57]

Deoilpanized.

[sof, 2016-01-16 20:02:19]

On 2016/01/16 19:43:57, kozyatinskiy wrote:
> Deoilpanized.

makes for an easy review for oilpan-reviews@ :) , so this appears ready % patch
dependencies.

[kozy, 2016-01-19 19:01:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-01-19 19:01:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1579283002/#ps180001
(title: "deoilpanize")

[commit-bot: I haz the power, 2016-01-19 19:03:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579283002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579283002/180001

[commit-bot: I haz the power, 2016-01-19 20:37:07]

Description was changed from

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews
==========

to

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews
==========

[commit-bot: I haz the power, 2016-01-19 20:37:08]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2016-01-19 20:39:12]

Description was changed from

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews
==========

to

==========
[DevTools] Blackbox sources with inline source maps

BUG=341082
R=pfeldman@chromium.org,dgozman@chromium.org, oilpan-reviews

Committed: https://crrev.com/8f131d2e7ed396d2f68d6762f0eb414f1ed8fae4
Cr-Commit-Position: refs/heads/master@{#370182}
==========

[commit-bot: I haz the power, 2016-01-19 20:39:12]

Patchset 7 (id:??) landed as
https://crrev.com/8f131d2e7ed396d2f68d6762f0eb414f1ed8fae4
Cr-Commit-Position: refs/heads/master@{#370182}