Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1583383003: [DevTools] Send source map content from frontend to backend (Closed)

Created:
4 years, 11 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@blackbox-inline-source-map
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Send source map content from frontend to backend Not inline source maps support. BUG=341082 R=dgozman@chromium.org,pfeldman@chromium.org

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : deoilpanized #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 5

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -89 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/resources/framework-with-sourcemap.js View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-source-map-and-blackboxing.html View 1 2 3 4 5 6 7 8 9 2 chunks +33 lines, -9 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-source-map-and-blackboxing-expected.txt View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/SourceMap.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp View 1 2 3 4 5 6 7 8 9 9 chunks +24 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp View 1 2 3 4 5 6 7 8 9 6 chunks +64 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerScript.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerScript.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 2 3 4 5 6 7 8 9 3 chunks +17 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 4 5 6 7 8 9 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1649553002 Patch 1

Messages

Total messages: 15 (5 generated)
kozy
ptal
4 years, 11 months ago (2016-01-16 01:33:50 UTC) #4
kozy
Ready for review, please take a look.
4 years, 11 months ago (2016-01-16 19:49:49 UTC) #7
pfeldman
https://codereview.chromium.org/1583383003/diff/80001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/80001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode1522 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1522: OwnPtr<SourceMap> sourceMap = parseSourceMapFromDataUrl(sourceMapURL); It'be nice if it went ...
4 years, 11 months ago (2016-01-19 19:35:04 UTC) #8
kozy
All done. https://codereview.chromium.org/1583383003/diff/80001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/80001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode1522 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1522: OwnPtr<SourceMap> sourceMap = parseSourceMapFromDataUrl(sourceMapURL); On 2016/01/19 19:35:04, ...
4 years, 11 months ago (2016-01-20 00:41:22 UTC) #9
pfeldman
https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode531 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:531: scriptURL = "/" + scriptURL; Why is this being ...
4 years, 11 months ago (2016-01-20 19:30:13 UTC) #10
kozy
https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode531 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:531: scriptURL = "/" + scriptURL; On 2016/01/20 19:30:13, pfeldman ...
4 years, 11 months ago (2016-01-20 23:21:22 UTC) #11
pfeldman
https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode535 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:535: scriptURL = "debugger:///VM" + String::number(frame->sourceID()); Wait we should not ...
4 years, 11 months ago (2016-01-21 19:27:15 UTC) #12
kozy
All done! https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1583383003/diff/160001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp#newcode535 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:535: scriptURL = "debugger:///VM" + String::number(frame->sourceID()); On 2016/01/21 ...
4 years, 10 months ago (2016-01-28 01:10:39 UTC) #13
pfeldman
Here is an attack factor that makes this not lgtm: eval("1\n//# sourceURL=www.google.com") we should never ...
4 years, 10 months ago (2016-01-28 03:03:52 UTC) #14
kozy
4 years, 10 months ago (2016-02-16 19:32:26 UTC) #15 
Different approach was implemented: frontend send to backend calculated blackbox
ranges.
https://codereview.chromium.org/1663723002/

Powered by Google App Engine
This is Rietveld 408576698