Reland [DevTools] Added base SourceMap implementation on backend

Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews

Committed: https://crrev.com/b81836e9825f78680fdd6f79fc9ae1fd0c7e8069
Cr-Commit-Position: refs/heads/master@{#369960}

[kozy, 2016-01-15 01:23:38]

Description was changed from

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews
==========

to

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews
==========

[kozy, 2016-01-15 01:24:15]

I need oilpan review.
I'm not sure about using OwnPtrWillBeRawPtr in SourceMapTest.cpp file in
TEST(SourceMapTest, FindEntry) test.
Please take a look!

[sof, 2016-01-16 07:25:05]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2016-01-16 07:25:05]

https://codereview.chromium.org/1587933004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/SourceMap.h (right):

https://codereview.chromium.org/1587933004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/SourceMap.h:22: class CORE_EXPORT
Entry: public NoBaseWillBeGarbageCollectedFinalized<SourceMap> {
Unless Entry will gain fields that refer to Oilpan heap objects, there's no
reason to keep this class on the Oilpan heap.

If so, I'd remove all uses of Oilpan types from SourceMap (=> do the same for
https://codereview.chromium.org/1579283002/ and remove its use of a persistent
heap hash map.)

(The reverted previous version of this CL failed because it used
adoptPtrWillBeNoop() where adoptPtr() would have sufficed.)

[kozy, 2016-01-16 19:34:44]

On 2016/01/16 07:25:05, sof wrote:
>
https://codereview.chromium.org/1587933004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/inspector/v8/SourceMap.h (right):
> 
>
https://codereview.chromium.org/1587933004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/inspector/v8/SourceMap.h:22: class CORE_EXPORT
> Entry: public NoBaseWillBeGarbageCollectedFinalized<SourceMap> {
> Unless Entry will gain fields that refer to Oilpan heap objects, there's no
> reason to keep this class on the Oilpan heap.
> 
> If so, I'd remove all uses of Oilpan types from SourceMap (=> do the same for
> https://codereview.chromium.org/1579283002/ and remove its use of a persistent
> heap hash map.)
> 
> (The reverted previous version of this CL failed because it used
> adoptPtrWillBeNoop() where adoptPtr() would have sufficed.)

Thank you!
I've deoilpanized this class.

[kozy, 2016-01-16 19:34:49]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-01-16 19:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587933004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587933004/20001

[sof, 2016-01-16 19:56:33]

lgtm

https://codereview.chromium.org/1587933004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/SourceMap.h (right):

https://codereview.chromium.org/1587933004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/SourceMap.h:19:
WTF_MAKE_NONCOPYABLE(SourceMap);
Perhaps add USING_FAST_MALLOC(SourceMap) and on Entry?

https://codereview.chromium.org/1587933004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/SourceMap.h:30: Entry(int line, int
column, const String& sourceURL = String(), int sourceLine = 0, int sourceColumn
= 0);
nit: the sites constructing Entry objects would look tidier if you had a
create(...) factory method.

[commit-bot: I haz the power, 2016-01-16 22:55:23]

Description was changed from

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews
==========

to

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews
==========

[commit-bot: I haz the power, 2016-01-16 22:55:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-16 22:56:26]

Description was changed from

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews
==========

to

==========
Reland [DevTools] Added base SourceMap implementation on backend

Oilpan build is fixed.
Original CL: https://codereview.chromium.org/1574133002/

BUG=341082
TBR=pfeldman@chromium.org,lushnikov@chromium.org,dgozman@chromium.org
R=oilpan-reviews

Committed: https://crrev.com/b81836e9825f78680fdd6f79fc9ae1fd0c7e8069
Cr-Commit-Position: refs/heads/master@{#369960}
==========

[commit-bot: I haz the power, 2016-01-16 22:56:27]

Patchset 2 (id:??) landed as
https://crrev.com/b81836e9825f78680fdd6f79fc9ae1fd0c7e8069
Cr-Commit-Position: refs/heads/master@{#369960}

[haraken, 2016-01-17 00:29:52]

LGTM