third_party/WebKit/Source/core/dom/Element.cpp - Issue 1578263006: Add metrics for usage of permission features from iframes in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 821c32e723c337e8c0af2ab83076536f7bb52cce..a533d41cb10ab97d147235fc2528ce55f3ef18ec 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -3041,6 +3041,7 @@ void Element::setIsInTopLayer(bool inTopLayer)

void Element::requestPointerLock()

{

+ UseCounter::countCrossOriginIframe(document(), UseCounter::ElementRequestPointerLockIframe);

mlamouri (slow - plz ping) 2016/01/19 17:54:48 Maybe you could move this into `PointerLockControl

raymes 2016/01/20 00:13:12 Done. Is that just to keep code out of Element.cpp

mlamouri (slow - plz ping) 2016/01/21 13:53:18 Yes.

if (document().page())

document().page()->pointerLockController().requestPointerLock(this);

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('J')