Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3023 matching lines...) Expand 10 before | Expand all | Expand 10 after
3034 return; 3034 return;
3035 setElementFlag(IsInTopLayer, inTopLayer); 3035 setElementFlag(IsInTopLayer, inTopLayer);
3036 3036
3037 // We must ensure a reattach occurs so the layoutObject is inserted in the c orrect sibling order under LayoutView according to its 3037 // We must ensure a reattach occurs so the layoutObject is inserted in the c orrect sibling order under LayoutView according to its
3038 // top layer position, or in its usual place if not in the top layer. 3038 // top layer position, or in its usual place if not in the top layer.
3039 lazyReattachIfAttached(); 3039 lazyReattachIfAttached();
3040 } 3040 }
3041 3041
3042 void Element::requestPointerLock() 3042 void Element::requestPointerLock()
3043 { 3043 {
3044 UseCounter::countCrossOriginIframe(document(), UseCounter::ElementRequestPoi nterLockIframe);
mlamouri (slow - plz ping) 2016/01/19 17:54:48 Maybe you could move this into `PointerLockControl
raymes 2016/01/20 00:13:12 Done. Is that just to keep code out of Element.cpp
mlamouri (slow - plz ping) 2016/01/21 13:53:18 Yes.
3044 if (document().page()) 3045 if (document().page())
3045 document().page()->pointerLockController().requestPointerLock(this); 3046 document().page()->pointerLockController().requestPointerLock(this);
3046 } 3047 }
3047 3048
3048 SpellcheckAttributeState Element::spellcheckAttributeState() const 3049 SpellcheckAttributeState Element::spellcheckAttributeState() const
3049 { 3050 {
3050 const AtomicString& value = fastGetAttribute(spellcheckAttr); 3051 const AtomicString& value = fastGetAttribute(spellcheckAttr);
3051 if (value == nullAtom) 3052 if (value == nullAtom)
3052 return SpellcheckAttributeDefault; 3053 return SpellcheckAttributeDefault;
3053 if (equalIgnoringCase(value, "true") || equalIgnoringCase(value, "")) 3054 if (equalIgnoringCase(value, "true") || equalIgnoringCase(value, ""))
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
3649 { 3650 {
3650 #if ENABLE(OILPAN) 3651 #if ENABLE(OILPAN)
3651 if (hasRareData()) 3652 if (hasRareData())
3652 visitor->trace(elementRareData()); 3653 visitor->trace(elementRareData());
3653 visitor->trace(m_elementData); 3654 visitor->trace(m_elementData);
3654 #endif 3655 #endif
3655 ContainerNode::trace(visitor); 3656 ContainerNode::trace(visitor);
3656 } 3657 }
3657 3658
3658 } // namespace blink 3659 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698