Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.h

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h b/third_party/WebKit/Source/core/frame/UseCounter.h
index 338db02e52f226a97585e4ed89fea84e4e8bef1a..f81f2ae8237f2d7c5f0f1f6dd5b77be5efc97ace 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -971,6 +971,13 @@ public:
SVG1DOMImageElement = 1115,
SVG1DOMForeignObjectElement = 1116,
AudioContextCreateIIRFilter = 1117,
+ GeolocationInsecureOriginIframe = 1118,
+ GeolocationSecureOriginIframe = 1119,
+ RequestMIDIAccessIframe = 1120,
+ GetUserMediaSecureOriginIframe = 1121,
+ ElementRequestPointerLockIframe = 1122,
+ NotificationAPIInsecureOriginIframe = 1123,
+ NotificationAPISecureOriginIframe = 1124,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
@@ -1013,6 +1020,9 @@ public:
static void countDeprecationIfNotPrivateScript(v8::Isolate*, ExecutionContext*, Feature);
static String deprecationMessage(Feature);
+ // Count only features if they're being used in a cross-origin iframe.
+ static void countCrossOriginIframe(const Document&, Feature);
+
// Return whether the Feature was previously counted for this document.
// NOTE: only for use in testing.
static bool isCounted(Document&, Feature);

Powered by Google App Engine
This is Rietveld 408576698